8338306: WebView Drag and Drop fails with WebKit 619.1

[HimaBinduMeda]

This commit resolves drag and drop issue observed with Webkit-619.1. Verified build on all platforms. No issue seen

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8338306: WebView Drag and Drop fails with WebKit 619.1 (Bug - P2)

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Joeri Sykora (@tiainen - Author)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1538/head:pull/1538
$ git checkout pull/1538

Update a local copy of the PR:
$ git checkout pull/1538
$ git pull https://git.openjdk.org/jfx.git pull/1538/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1538

View PR using the GUI difftool:
$ git pr show -t 1538

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1538.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338306: WebView Drag and Drop fails with WebKit 619.1

Reviewed-by: kcr, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• f1bac5a: 8336938: Update libFFI to 3.4.6
• 269d689: 8338478: [macos] Crash in CoreText with certain strings using JDK 22 or later

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (7ef15ec2)
• 00: Full (4a127528)

[kevinrushforth]

Reviewers: @kevinrushforth and @tiainen or @johanvos

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

The fix works as expected. I confirm that Drag and Drop fails without the fix and works with the fix.

I left a suggestion and a question inline.

[kevinrushforth]

One other question: what was the root cause of this bug? Did WebKit recently change how the different DnD-related events are delivered?

[kevinrushforth]

Thanks for the explanation. The updated fix looks good.

[tiainen]

Looking good.

[HimaBinduMeda]

/integrate

[openjdk]

Going to push as commit 67ac9d7.
Since your change was applied there have been 2 commits pushed to the master branch:

• f1bac5a: 8336938: Update libFFI to 3.4.6
• 269d689: 8338478: [macos] Crash in CoreText with certain strings using JDK 22 or later

Your commit was automatically rebased without conflicts.

[openjdk]

@HimaBinduMeda Pushed as commit 67ac9d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.