-
Notifications
You must be signed in to change notification settings - Fork 520
8336632: Update Gradle to 8.9 #1539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back arapte! A progress list of the required criteria for merging this PR into |
@arapte This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
@arapte |
Webrevs
|
Reviewers: @kevinrushforth @tiainen /reviewers 2 |
@kevinrushforth |
The gradle update looks good. You missed updating the boot JDK for Windows in the GHA build. Also, can you merge in the latest master? |
A few days ago I tested 8.9 and it worked well. I would suggested in another PR to have a single constant with the Java version and not updated 12 places to the same version. |
Thanks Kevin, Updated the GHA and merged with latest master. |
This is tracked by https://bugs.openjdk.org/browse/JDK-8255712 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I've tested with gradle 8.9 and JDK 22.0.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All builds succeeded with the newest gradle and JDK 22.
/integrate |
Gradle 8.8 released on May 31, 2024, supports JDK 22.
On Jul 11, 2024, gradle 8.9 was released too, so we can update to the latest gradle 8.9
This gradle update is required in order to update the boot jdk to 22.0.2.
The changes are minimal, no source code changes were required.
This PR also includes the boot jdk update.
/issue add JDK-8336633
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1539/head:pull/1539
$ git checkout pull/1539
Update a local copy of the PR:
$ git checkout pull/1539
$ git pull https://git.openjdk.org/jfx.git pull/1539/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1539
View PR using the GUI difftool:
$ git pr show -t 1539
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1539.diff
Webrev
Link to Webrev Comment