Skip to content

8336632: Update Gradle to 8.9 #1539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Conversation

arapte
Copy link
Member

@arapte arapte commented Aug 20, 2024

Gradle 8.8 released on May 31, 2024, supports JDK 22.
On Jul 11, 2024, gradle 8.9 was released too, so we can update to the latest gradle 8.9

This gradle update is required in order to update the boot jdk to 22.0.2.
The changes are minimal, no source code changes were required.

This PR also includes the boot jdk update.

/issue add JDK-8336633


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1539/head:pull/1539
$ git checkout pull/1539

Update a local copy of the PR:
$ git checkout pull/1539
$ git pull https://git.openjdk.org/jfx.git pull/1539/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1539

View PR using the GUI difftool:
$ git pr show -t 1539

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1539.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2024

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 20, 2024

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336632: Update Gradle to 8.9
8336633: Update boot JDK to 22.0.2

Reviewed-by: kcr, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 67ac9d7: 8338306: WebView Drag and Drop fails with WebKit 619.1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Aug 20, 2024

@arapte
Adding additional issue to issue list: 8336633: Update boot JDK to 22.0.2.

@openjdk openjdk bot added the rfr Ready for review label Aug 20, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 20, 2024

Webrevs

@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @tiainen

/reviewers 2

@kevinrushforth kevinrushforth self-requested a review August 20, 2024 11:51
@openjdk
Copy link

openjdk bot commented Aug 20, 2024

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@kevinrushforth
Copy link
Member

The gradle update looks good. You missed updating the boot JDK for Windows in the GHA build. Also, can you merge in the latest master?

@nlisker
Copy link
Collaborator

nlisker commented Aug 20, 2024

A few days ago I tested 8.9 and it worked well.

I would suggested in another PR to have a single constant with the Java version and not updated 12 places to the same version.

@arapte
Copy link
Member Author

arapte commented Aug 20, 2024

The gradle update looks good. You missed updating the boot JDK for Windows in the GHA build. Also, can you merge in the latest master?

Thanks Kevin, Updated the GHA and merged with latest master.

@kevinrushforth
Copy link
Member

I would suggested in another PR to have a single constant with the Java version and not updated 12 places to the same version.

This is tracked by https://bugs.openjdk.org/browse/JDK-8255712

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've tested with gradle 8.9 and JDK 22.0.2.

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All builds succeeded with the newest gradle and JDK 22.

@openjdk openjdk bot added the ready Ready to be integrated label Aug 21, 2024
@arapte
Copy link
Member Author

arapte commented Aug 21, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Aug 21, 2024

Going to push as commit b898731.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 67ac9d7: 8338306: WebView Drag and Drop fails with WebKit 619.1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 21, 2024
@openjdk openjdk bot closed this Aug 21, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Aug 21, 2024
@openjdk
Copy link

openjdk bot commented Aug 21, 2024

@arapte Pushed as commit b898731.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants