-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8338307 : Additional WebKit 619.1 fixes from WebKitGTK 2.44.3 #1541
Conversation
👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into |
@HimaBinduMeda This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Reviewers: @kevinrushforth @tiainen /reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The code changes match those in the upstream webkitgtk-2.44.3
tag. I did a build and sanity test. All good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds and tests were successful on our infrastructure.
/integrate |
@HimaBinduMeda Pushed as commit aa52f7e. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Updated additonal fixes from webkit-2.44.3. Verified build on all platforms. No issue seen.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1541/head:pull/1541
$ git checkout pull/1541
Update a local copy of the PR:
$ git checkout pull/1541
$ git pull https://git.openjdk.org/jfx.git pull/1541/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1541
View PR using the GUI difftool:
$ git pr show -t 1541
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1541.diff
Webrev
Link to Webrev Comment