Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338307 : Additional WebKit 619.1 fixes from WebKitGTK 2.44.3 #1541

Closed
wants to merge 2 commits into from

Conversation

HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented Aug 21, 2024

Updated additonal fixes from webkit-2.44.3. Verified build on all platforms. No issue seen.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8338307: Additional WebKit 619.1 fixes from WebKitGTK 2.44.3 (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1541/head:pull/1541
$ git checkout pull/1541

Update a local copy of the PR:
$ git checkout pull/1541
$ git pull https://git.openjdk.org/jfx.git pull/1541/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1541

View PR using the GUI difftool:
$ git pr show -t 1541

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1541.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2024

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 21, 2024

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338307: Additional WebKit 619.1 fixes from WebKitGTK 2.44.3

Reviewed-by: kcr, sykora

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • fac1c2a: 8338849: Update copyright header for files modified in 2024
  • b898731: 8336632: Update Gradle to 8.9

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@HimaBinduMeda HimaBinduMeda marked this pull request as ready for review August 22, 2024 14:26
@openjdk openjdk bot added the rfr Ready for review label Aug 22, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 22, 2024

Webrevs

@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @tiainen

/reviewers 2

@kevinrushforth kevinrushforth self-requested a review August 22, 2024 16:51
@openjdk
Copy link

openjdk bot commented Aug 22, 2024

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The code changes match those in the upstream webkitgtk-2.44.3 tag. I did a build and sanity test. All good.

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and tests were successful on our infrastructure.

@openjdk openjdk bot added the ready Ready to be integrated label Aug 23, 2024
@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 23, 2024

Going to push as commit aa52f7e.
Since your change was applied there have been 2 commits pushed to the master branch:

  • fac1c2a: 8338849: Update copyright header for files modified in 2024
  • b898731: 8336632: Update Gradle to 8.9

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 23, 2024
@openjdk openjdk bot closed this Aug 23, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Aug 23, 2024
@openjdk
Copy link

openjdk bot commented Aug 23, 2024

@HimaBinduMeda Pushed as commit aa52f7e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants