8338886: JavaFX debug builds fail on macOS

[jaybhaskar]

Issue: ASSERT Statement: The ASSERT macro or function seems to be used to check if a condition involving ExceptionCode is true, but it's failing to compile.
Solution: The expression for ASSERT should be checked with type.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8338886: JavaFX debug builds fail on macOS (Bug - P3)

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1544/head:pull/1544
$ git checkout pull/1544

Update a local copy of the PR:
$ git checkout pull/1544
$ git pull https://git.openjdk.org/jfx.git pull/1544/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1544

View PR using the GUI difftool:
$ git pr show -t 1544

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1544.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jbhaskar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaybhaskar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338886: JavaFX debug builds fail on macOS

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• aa52f7e: 8338307: Additional WebKit 619.1 fixes from WebKitGTK 2.44.3
• fac1c2a: 8338849: Update copyright header for files modified in 2024

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (40b6e12d)

[kevinrushforth]

This is a trivial fix that only affects a debug build. It does not affect production builds or ordinary developer builds. A single reviewer is sufficient.

The fix looks good. I can now build in debug mode using: gradle -PCONF=DebugNative

Running the debug build on my M1 Mac and loading a non-trivial web page crashes after a short time with a call to "abort()", but that's unrelated to this build failure and should be handled as a follow-on bug.

[jaybhaskar]

/integrate

[openjdk]

Going to push as commit 4849716.
Since your change was applied there have been 2 commits pushed to the master branch:

• aa52f7e: 8338307: Additional WebKit 619.1 fixes from WebKitGTK 2.44.3
• fac1c2a: 8338849: Update copyright header for files modified in 2024

Your commit was automatically rebased without conflicts.

[openjdk]

@jaybhaskar Pushed as commit 4849716.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.