8334124: Rendering issues with CSS "text-shadow" in WebView

[Schmidor]

On a Shadow state update with cleared shadow, the new values were not transmitted to the Java GraphicsDecoder

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8334124: Rendering issues with CSS "text-shadow" in WebView (Bug - P3)

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Jay Bhaskar (@jaybhaskar - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1547/head:pull/1547
$ git checkout pull/1547

Update a local copy of the PR:
$ git checkout pull/1547
$ git pull https://git.openjdk.org/jfx.git pull/1547/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1547

View PR using the GUI difftool:
$ git pr show -t 1547

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1547.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back Schmidor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Schmidor This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334124: Rendering issues with CSS "text-shadow" in WebView

Reviewed-by: kcr, jbhaskar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• ca70a07: 8337481: File API: file.name contains path instead of name
• a53bc58: 8339236: Suppress removal warnings for Security Manager methods in iOS sources

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @jaybhaskar) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 02: Full - Incremental (831aa443)
• 01: Full - Incremental (c0e4adcb)
• 00: Full (e86686e2)

[kevinrushforth]

Reviewers: @kevinrushforth @jaybhaskar

/reviewers 2

[kevinrushforth]

@Schmidor Would it be possible to add an automated test for this?

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[Schmidor]

I've added one: Counting pixels in an area for checking whether the shadow is rendered at the appropriate text and not on the other.

[kevinrushforth]

The fix looks good. I verified it with the test program attached to the bug report. I also confirm that the newly added test fails without the fix and passes with the fix.

I left a few mostly minor comments on the test.

[kevinrushforth]

Looks good now. Test still passes.

[jaybhaskar]

The fix looks good, it passes with fix and fail without fix.

[Schmidor]

/integrate

[openjdk]

@Schmidor
Your change (at version 831aa44) is now ready to be sponsored by a Committer.

[jaybhaskar]

/sponser

[openjdk]

@jaybhaskar Unknown command sponser - for a list of valid commands use /help.

[jaybhaskar]

/sponsor

[openjdk]

Going to push as commit e0ceafb.
Since your change was applied there have been 2 commits pushed to the master branch:

• ca70a07: 8337481: File API: file.name contains path instead of name
• a53bc58: 8339236: Suppress removal warnings for Security Manager methods in iOS sources

Your commit was automatically rebased without conflicts.

[openjdk]

@jaybhaskar @Schmidor Pushed as commit e0ceafb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.