Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8230809: HTMLEditor formatting lost when selecting all (CTRL-A) #155

wants to merge 1 commit into from


Copy link

@aghaisas aghaisas commented Apr 1, 2020

Bug :

Root Cause :
Turned out to be a simpler issue than thought.
Atomicity check was missed while updating toolbar state (which in turn updates styles).

Fix :
Added the missed atomicity check at two places that handle text selection using keyboard keys.

Testing :
Added two system test cases. They fail without this fix and pass with it.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


  • JDK-8230809: HTMLEditor formatting lost when selecting all (CTRL-A)


  • Arun Joseph (ajoseph - Author)
  • Kevin Rushforth (kcr - Reviewer)


$ git fetch pull/155/head:pull/155
$ git checkout pull/155

Copy link

bridgekeeper bot commented Apr 1, 2020

👋 Welcome back aghaisas! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr Ready for review label Apr 1, 2020
Copy link

mlbridge bot commented Apr 1, 2020


Copy link

/reviewers 2

@kevinrushforth kevinrushforth self-requested a review April 6, 2020 23:41
Copy link

openjdk bot commented Apr 6, 2020

The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link

@guruhb can you also review this?

Copy link

openjdk bot commented Apr 7, 2020

@aghaisas This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8230809: HTMLEditor formatting lost when selecting all (CTRL-A)

Reviewed-by: ajoseph, kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 7 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate fda015c6df79968bd524c229bfb31299ea91a380.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready Ready to be integrated label Apr 7, 2020
Copy link
Collaborator Author

aghaisas commented Apr 8, 2020


@openjdk openjdk bot closed this Apr 8, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Ready to be integrated labels Apr 8, 2020
Copy link

openjdk bot commented Apr 8, 2020

@aghaisas The following commits have been pushed to master since your change was applied:

  • fda015c: 8242167: ios keyboard handling
  • 844460b: 8242163: Android keyboard integration fails
  • 364c64a: 8241249: NPE in TabPaneSkin.perfromDrag
  • 418675a: 8236840: Memory leak when switching ButtonSkin
  • 247a65d: 8236971: [macos] Gestures handled incorrectly due to missing events
  • 560ef17: 8241455: Memory leak on replacing selection/focusModel
  • 5906521: 8241370: Crash in JPEGImageLoader after fix for JDK-8212034

Your commit was automatically rebased without conflicts.

Pushed as commit 470c7d0.

@openjdk openjdk bot removed the rfr Ready for review label Apr 8, 2020
@aghaisas aghaisas deleted the HTMLEditor_fix branch April 13, 2020 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
integrated Pull request has been integrated
3 participants