8337481: File API: file.name contains path instead of name

[Schmidor]

FileSystemJava had no valid implementation for pathFileName since the function was renamed from pathGetFileName to pathFileName in the FileSystem.h from WebKit

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8337481: File API: file.name contains path instead of name (Bug - P3)

Reviewers

• Ambarish Rapte (@arapte - Reviewer)
• Hima Bindu Meda (@HimaBinduMeda - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1551/head:pull/1551
$ git checkout pull/1551

Update a local copy of the PR:
$ git checkout pull/1551
$ git pull https://git.openjdk.org/jfx.git pull/1551/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1551

View PR using the GUI difftool:
$ git pr show -t 1551

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1551.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back Schmidor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Schmidor This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337481: File API: file.name contains path instead of name

Reviewed-by: arapte, hmeda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• a53bc58: 8339236: Suppress removal warnings for Security Manager methods in iOS sources

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@arapte, @HimaBinduMeda) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 02: Full - Incremental (af515ffb)
• 01: Full - Incremental (85d11d4e)
• 00: Full (328f32b8)

[kevinrushforth]

Reviewers: @arapte @HimaBinduMeda

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

The fix looks reasonable to me, but I'll let @arapte be the primary reviewer, so this isn't a formal review.

I was testing #1547 anyway, so I created a test branch with both that fix and this one merged together and ran it through our CI system. I confirm that the newly added test for this PR fails without the fix and passes with the fix.

[arapte]

The change looks good, For reference the related change in Webkit repo is : WebKit/WebKit@3cab8bc
Provided a few comments that need to be attended.
Verified that test fails without this patch and passes with it.

[arapte]

LGTM

[HimaBinduMeda]

Changes look fine. Verified that full file path is shown without the fix . With the fix, only the file name is shown, as expected.

[Schmidor]

/integrate

[openjdk]

@Schmidor
Your change (at version af515ff) is now ready to be sponsored by a Committer.

[kevinrushforth]

/sponsor

[openjdk]

Going to push as commit ca70a07.
Since your change was applied there has been 1 commit pushed to the master branch:

• a53bc58: 8339236: Suppress removal warnings for Security Manager methods in iOS sources

Your commit was automatically rebased without conflicts.

[openjdk]

@kevinrushforth @Schmidor Pushed as commit ca70a07.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.