Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338701: Provide media support for libavcodec version 61 #1552

Closed
wants to merge 1 commit into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Aug 29, 2024

  • Added support for libavcodec 61.
  • Updated AV plugins to use new APIs instead of APIs which were removed in 61.
  • We still using some deprecated APIs.
  • reordered_opaque replacement exist in 61 which is used to pass user data between compressed frame and uncompressed. In 61 this variable is pointer to void instead of int64_t. We can use new opaque to pass PTS, but it is not documented way to pass PTS between compressed and uncompressed frames. Updated code will be using AVPacket.pts/AVFrame.pts which is documented way to provide PTS.
  • Tested on Ubuntu 24.10 with 61 and 24.04 with 60 with all supported formats.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8338701: Provide media support for libavcodec version 61 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1552/head:pull/1552
$ git checkout pull/1552

Update a local copy of the PR:
$ git checkout pull/1552
$ git pull https://git.openjdk.org/jfx.git pull/1552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1552

View PR using the GUI difftool:
$ git pr show -t 1552

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1552.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 29, 2024

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 29, 2024

@sashamatveev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338701: Provide media support for libavcodec version 61

Reviewed-by: sykora, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • e0ceafb: 8334124: Rendering issues with CSS "text-shadow" in WebView
  • ca70a07: 8337481: File API: file.name contains path instead of name
  • a53bc58: 8339236: Suppress removal warnings for Security Manager methods in iOS sources

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Ready for review label Aug 29, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 29, 2024

Webrevs

@kevinrushforth
Copy link
Member

Reviewers: @arapte @tiainen

/reviewers 2

@kevinrushforth kevinrushforth requested a review from arapte August 29, 2024 21:47
@openjdk
Copy link

openjdk bot commented Aug 29, 2024

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Collaborator

@tiainen tiainen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything went fine with the builds.

@openjdk openjdk bot added the ready Ready to be integrated label Sep 2, 2024
@sashamatveev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 3, 2024

Going to push as commit 6115b39.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 4652282: 8339178: [macos] Swing InterOp Platform.exit() crash
  • 2bf8ffc: 8339212: gradle downloads x64 binary of SWT on Linux/aarch64
  • e0ceafb: 8334124: Rendering issues with CSS "text-shadow" in WebView
  • ca70a07: 8337481: File API: file.name contains path instead of name
  • a53bc58: 8339236: Suppress removal warnings for Security Manager methods in iOS sources

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 3, 2024
@openjdk openjdk bot closed this Sep 3, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Sep 3, 2024
@openjdk
Copy link

openjdk bot commented Sep 3, 2024

@sashamatveev Pushed as commit 6115b39.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants