-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8338701: Provide media support for libavcodec version 61 #1552
Conversation
👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into |
@sashamatveev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything went fine with the builds.
/integrate |
Going to push as commit 6115b39.
Your commit was automatically rebased without conflicts. |
@sashamatveev Pushed as commit 6115b39. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
reordered_opaque
replacement exist in 61 which is used to pass user data between compressed frame and uncompressed. In 61 this variable is pointer tovoid
instead ofint64_t
. We can use newopaque
to pass PTS, but it is not documented way to pass PTS between compressed and uncompressed frames. Updated code will be usingAVPacket.pts/AVFrame.pts
which is documented way to provide PTS.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1552/head:pull/1552
$ git checkout pull/1552
Update a local copy of the PR:
$ git checkout pull/1552
$ git pull https://git.openjdk.org/jfx.git pull/1552/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1552
View PR using the GUI difftool:
$ git pr show -t 1552
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1552.diff
Webrev
Link to Webrev Comment