8242163: Android keyboard integration fails

[johanvos]

Fix the code that integrates TextField/TextArea with the android keyboard

Fix for #8242163

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8242163: Android keyboard integration fails

Reviewers

• Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/157/head:pull/157
$ git checkout pull/157

[bridgekeeper]

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 00: Full (3eb6c9a)

[kevinrushforth]

Similar question as for the IOS keyboard issue: The newly moved TextAreaSkinAndroid and TextFieldSkinAndroid classes will become part of the public API for Android, since they are in the javafx.scene.control.skin package. Is this intended, or might they still be able to live somewhere under com.sun.javafx?

[johanvos]

Same reason as in the iOS case. The TextFieldSkinAndroid was in com.sun.javafx at the same level as TextFieldSkin. Since TextFieldSkin was moved to javafx, I moved TextFieldSkinAndroid as well.

[openjdk]

@johanvos This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242163: Android keyboard integration fails

Reviewed-by: kcr

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 364c64a2e55b561df4ca1afc85c91054b339eea8.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

[johanvos]

/integrate

[openjdk]

@johanvos The following commits have been pushed to master since your change was applied:

• 364c64a: 8241249: NPE in TabPaneSkin.perfromDrag
• 418675a: 8236840: Memory leak when switching ButtonSkin
• 247a65d: 8236971: [macos] Gestures handled incorrectly due to missing events
• 560ef17: 8241455: Memory leak on replacing selection/focusModel

Your commit was automatically rebased without conflicts.

Pushed as commit 844460b.