Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242163: Android keyboard integration fails #157

Closed
wants to merge 1 commit into from

Conversation

@johanvos
Copy link
Collaborator

@johanvos johanvos commented Apr 5, 2020

Fix the code that integrates TextField/TextArea with the android keyboard

Fix for #8242163


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/157/head:pull/157
$ git checkout pull/157

…oard

Fix for #8242163
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 5, 2020

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Apr 5, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 5, 2020

Webrevs

@johanvos johanvos self-assigned this Apr 6, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 6, 2020

Similar question as for the IOS keyboard issue: The newly moved TextAreaSkinAndroid and TextFieldSkinAndroid classes will become part of the public API for Android, since they are in the javafx.scene.control.skin package. Is this intended, or might they still be able to live somewhere under com.sun.javafx?

@johanvos
Copy link
Collaborator Author

@johanvos johanvos commented Apr 7, 2020

Same reason as in the iOS case. The TextFieldSkinAndroid was in com.sun.javafx at the same level as TextFieldSkin. Since TextFieldSkin was moved to javafx, I moved TextFieldSkinAndroid as well.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2020

@johanvos This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242163: Android keyboard integration fails

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 364c64a2e55b561df4ca1afc85c91054b339eea8.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 7, 2020
@johanvos
Copy link
Collaborator Author

@johanvos johanvos commented Apr 7, 2020

/integrate

@openjdk openjdk bot closed this Apr 7, 2020
@openjdk openjdk bot added integrated and removed ready labels Apr 7, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 7, 2020

@johanvos The following commits have been pushed to master since your change was applied:

  • 364c64a: 8241249: NPE in TabPaneSkin.perfromDrag
  • 418675a: 8236840: Memory leak when switching ButtonSkin
  • 247a65d: 8236971: [macos] Gestures handled incorrectly due to missing events
  • 560ef17: 8241455: Memory leak on replacing selection/focusModel

Your commit was automatically rebased without conflicts.

Pushed as commit 844460b.

@openjdk openjdk bot removed the rfr label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants