-
Notifications
You must be signed in to change notification settings - Fork 542
8340954: Add SECURITY.md file #1578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
|
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
| @@ -0,0 +1,3 @@ | |||
| # JavaFX Vulnerabilities | |||
|
|
|||
| Please follow the process outlined in the [OpenJDK Vulnerability Policy](https://openjdk.org/groups/vulnerability/report) to disclose vulnerabilities in JavaFX. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since FX is not technically a part of JDK, should it point to a separate (new) page instead of https://openjdk.org/groups/vulnerability/report ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. JavaFX is part of OpenJDK. It is irrelevant whether or not it happens to be bundled with the JDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Maran23
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, I think this is a good idea for both the JDK and JavaFX, as people who work primarily with Github will immediately find relevant security information in the relevant project.
|
/integrate |
|
Going to push as commit 0dd0c79. |
|
@kevinrushforth Pushed as commit 0dd0c79. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
/backport jfx23u |
|
@kevinrushforth the backport was successfully created on the branch backport-kevinrushforth-0dd0c794-master in my personal fork of openjdk/jfx23u. To create a pull request with this backport targeting openjdk/jfx23u:master, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx23u: |
A
SECURITY.mdfile was recently added to the jdk repo. GitHub will show that policy if you click on the "Security" tab of the jdk repo -- If you are logged in, you may need to further click on the "Policy" tab.We need a copy of this file in the jfx repo, so that similarly, you will see the policy if you click on the "Security" tab of the jfx repo -- if you are logged in, you may need to further click on the "Policy" tab.
The
SECURITY.mdfile in this PR is identical to the one in the jdk repo, with "JDK" replaced by "JavaFX" in two places (the section header and the name of the software).See openjdk/jdk#21155 for more details.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1578/head:pull/1578$ git checkout pull/1578Update a local copy of the PR:
$ git checkout pull/1578$ git pull https://git.openjdk.org/jfx.git pull/1578/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1578View PR using the GUI difftool:
$ git pr show -t 1578Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1578.diff
Webrev
Link to Webrev Comment