8242167: ios keyboard handling

[johanvos]

Use JavaFX controls for TextField and TextArea instead of the native iOS ones
This fixes JDK-8242167

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8242167: ios keyboard handling

Reviewers

• Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/158/head:pull/158
$ git checkout pull/158

[bridgekeeper]

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 00: Full (9f00fb6)

[kevinrushforth]

The new TextAreaSkinIos and TextFieldSkinIos classes will become part of the public API for IOS, since they are in the javafx.scene.control.skin package. Is this intended, or might they be able to live somewhere under com.sun.javafx?

[johanvos]

The new TextAreaSkinIos and TextFieldSkinIos classes will become part of the public API for IOS, since they are in the javafx.scene.control.skin package. Is this intended, or might they be able to live somewhere under com.sun.javafx?

That is intentional indeed, as libraries may want to change behavior. The Android classes used to be in com.sun.javafx, at the same level as the desktop classes. But the desktop classes (TextAreaSkin and TextFieldSkin) are moved to javafx.scene.control.skin hence it seems logic to move the Android classes to the same level, and the iOS classes as well then.
Alternatively, we could completely get rid of the ios/android specific classes, and add the logic to show/hide the keyboard in the desktop classes. But that is much more intrusive, so I think it's safer to keep them separated for now.

[openjdk]

@johanvos This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242167: ios keyboard handling

Reviewed-by: kcr

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 6 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate fda015c6df79968bd524c229bfb31299ea91a380.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

[johanvos]

/integrate

[openjdk]

@johanvos The following commits have been pushed to master since your change was applied:

• 844460b: 8242163: Android keyboard integration fails
• 364c64a: 8241249: NPE in TabPaneSkin.perfromDrag
• 418675a: 8236840: Memory leak when switching ButtonSkin
• 247a65d: 8236971: [macos] Gestures handled incorrectly due to missing events
• 560ef17: 8241455: Memory leak on replacing selection/focusModel

Your commit was automatically rebased without conflicts.

Pushed as commit fda015c.