Skip to content

8340003: Bump minimum JDK version for JavaFX to JDK 22 #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Oct 2, 2024

This PR bumps the minimum version of the JDK needed to run JavaFX to JDK 22.

In order for JavaFX to be able to use newer JDK features, such as FFM, we need to increase the minimum version of the JDK required run the latest JavaFX. Additionally, there is an ongoing cost to keeping JavaFX buildable and runnable on older versions of Java, and little reason to continue to do so.

This is targeted to JavaFX 24, and must not be backported to any earlier version. This needs a CSR and a release note.

/reviewers 2
/csr


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8341864 to be approved
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

  • JDK-8340003: Bump minimum JDK version for JavaFX to JDK 22 (Enhancement - P3)
  • JDK-8341864: Bump minimum JDK version for JavaFX to JDK 22 (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1588/head:pull/1588
$ git checkout pull/1588

Update a local copy of the PR:
$ git checkout pull/1588
$ git pull https://git.openjdk.org/jfx.git pull/1588/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1588

View PR using the GUI difftool:
$ git pr show -t 1588

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1588.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 2, 2024

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340003: Bump minimum JDK version for JavaFX to JDK 22

Reviewed-by: angorya, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • c4b1e1c: 8341686: FX: Update copyright year in docs, readme files to 2025
  • 1c86d3b: 8340850: Wrong bug ID listed as reason for skipping SwingNodePlatformExitCrashTest
  • 9c31cb0: 8340005: Eliminate native access calls from javafx.swing
  • 0cafd80: 8341920: Intermittent WebKit build failure on Windows generating PDB files in 619.1
  • cf55984: 8341440: ScrollPane: no immediate effect changing fitWidth/fitHeight
  • fbcbc98: 8341010: TriangleMesh.vertexFormat Property default value is wrong
  • fb06b1f: 8333374: Cannot invoke "com.sun.prism.RTTexture.contentsUseful()" because "this.txt" is null
  • ec60af4: 8087863: Mac: "Select All" within ListView/TreeView is handled differently depending on the useSystemMenuBar value
  • 1637f77: 8341418: Prism/es2 DrawableInfo is never freed (leak)
  • 23e2595: 8339068: [Linux] NPE: Cannot read field "firstFont" because "" is null
  • ... and 2 more: https://git.openjdk.org/jfx/compare/6e4d41b61b7efaafdfd9ea3f93cab9b7acb48de9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@openjdk openjdk bot added the csr Need approved CSR to integrate pull request label Oct 2, 2024
@openjdk
Copy link

openjdk bot commented Oct 2, 2024

@kevinrushforth has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@kevinrushforth please create a CSR request for issue JDK-8340003 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@kevinrushforth kevinrushforth marked this pull request as ready for review October 8, 2024 17:54
@openjdk openjdk bot added the rfr Ready for review label Oct 8, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 8, 2024

Webrevs

Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked against previous bumps - looks good.

@openjdk openjdk bot added ready Ready to be integrated and removed csr Need approved CSR to integrate pull request labels Oct 17, 2024
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 18, 2024

Going to push as commit f71c390.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 77482de: 8341372: BackgroundPosition, BorderImage, BorderStroke, CornerRadii should be final
  • c4b1e1c: 8341686: FX: Update copyright year in docs, readme files to 2025
  • 1c86d3b: 8340850: Wrong bug ID listed as reason for skipping SwingNodePlatformExitCrashTest
  • 9c31cb0: 8340005: Eliminate native access calls from javafx.swing
  • 0cafd80: 8341920: Intermittent WebKit build failure on Windows generating PDB files in 619.1
  • cf55984: 8341440: ScrollPane: no immediate effect changing fitWidth/fitHeight
  • fbcbc98: 8341010: TriangleMesh.vertexFormat Property default value is wrong
  • fb06b1f: 8333374: Cannot invoke "com.sun.prism.RTTexture.contentsUseful()" because "this.txt" is null
  • ec60af4: 8087863: Mac: "Select All" within ListView/TreeView is handled differently depending on the useSystemMenuBar value
  • 1637f77: 8341418: Prism/es2 DrawableInfo is never freed (leak)
  • ... and 3 more: https://git.openjdk.org/jfx/compare/6e4d41b61b7efaafdfd9ea3f93cab9b7acb48de9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 18, 2024
@openjdk openjdk bot closed this Oct 18, 2024
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Oct 18, 2024
@openjdk
Copy link

openjdk bot commented Oct 18, 2024

@kevinrushforth Pushed as commit f71c390.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kevinrushforth kevinrushforth deleted the 8340003-min-jdk-22 branch October 18, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants