8242209: Increase web native thread stack size for x86 mode

[arun-joseph]

CLoop interpreter used in 32-bit Windows uses 87 KB of stack space each time CLoop::execute() is called. For web native threads which has a default stack size of 320 KB, a Stack Overflow Error is raised just after two calls to execute() function. While 64-bit windows has a default stack size of 1 MB.

Fix: Increase the thread stack size of web native threads for x86 to 1 MB.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8242209: Increase web native thread stack size for x86 mode

Reviewers

• Kevin Rushforth (kcr - Reviewer)
• Guru Hb (ghb - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/159/head:pull/159
$ git checkout pull/159

[bridgekeeper]

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 00: Full (a71e59c)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[kevinrushforth]

@guruhb please also review this.

[guruhb]

Looks good to me, Tested on Windows with test case added in JBS.

[openjdk]

@arun-joseph This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242209: Increase web native thread stack size for x86 mode

Reviewed-by: kcr, ghb

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 11 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e1cb1911f0ecc82b69dd55dd1de4d9d3f23649fd.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @guruhb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[arun-joseph]

/integrate

[openjdk]

@arun-joseph
Your change (at version a71e59c) is now ready to be sponsored by a Committer.

[kevinrushforth]

/sponsor

[openjdk]

@kevinrushforth @arun-joseph The following commits have been pushed to master since your change was applied:

• e1cb191: 8240694: [macos 10.15] JavaFX Media hangs on some video files on Catalina
• c154538: 8242106: [macos] Remove obsolete GlassView2D.m class
• 3f663e3: 8240262: iOS refresh rate is capped to 30 Hz
• 231879a: 8241710: NullPointerException while entering empty submenu with "arrow right"
• 470c7d0: 8230809: HTMLEditor formatting lost when selecting all (CTRL-A)
• fda015c: 8242167: ios keyboard handling
• 844460b: 8242163: Android keyboard integration fails
• 364c64a: 8241249: NPE in TabPaneSkin.perfromDrag
• 418675a: 8236840: Memory leak when switching ButtonSkin
• 247a65d: 8236971: [macos] Gestures handled incorrectly due to missing events
• 560ef17: 8241455: Memory leak on replacing selection/focusModel

Your commit was automatically rebased without conflicts.

Pushed as commit b1fdc45.