8342457: Remove calls to doPrivileged in swing

[andy-goryachev-oracle]

Removes doPrivileged in the following module:

• javafx.swing

See JDK-8342441 for details.

As a helpful hint for reviewers, I recommend reviewing this using the "Hide whitespace" option.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8342457: Remove calls to doPrivileged in swing (Bug - P3)

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Prasanta Sadhukhan (@prsadhuk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1613/head:pull/1613
$ git checkout pull/1613

Update a local copy of the PR:
$ git checkout pull/1613
$ git pull https://git.openjdk.org/jfx.git pull/1613/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1613

View PR using the GUI difftool:
$ git pr show -t 1613

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1613.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342457: Remove calls to doPrivileged in swing

Reviewed-by: kcr, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 58cd76a: 8342456: Remove calls to doPrivileged in javafx.graphics/other
• 2234e84: 8342913: Remove calls to doPrivileged in media
• 33987a4: 8342912: Remove calls to doPrivileged in fxml
• d09cb78: 8340852: ScrollPane should not consume navigation keys when it doesn't have direct focus
• 73c85e7: 8342453: Remove calls to doPrivileged in javafx.graphics/com.sun.javafx.tk

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 01: Full - Incremental (0d9d2420)
• 00: Full (a812b2a8)

[kevinrushforth]

Looks good other than the one leftover @SuppressWarnings annotation I noted inline

/reviewers 2

[kevinrushforth]

The @SuppressWarnings("removal") annotation can be removed from the method.

[kevinrushforth]

@prsadhuk can you also review?

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[andy-goryachev-oracle]

/integrate

[openjdk]

Going to push as commit 6d69084.
Since your change was applied there have been 6 commits pushed to the master branch:

• 927f07b: 8342911: Remove calls to doPrivileged in controls
• 58cd76a: 8342456: Remove calls to doPrivileged in javafx.graphics/other
• 2234e84: 8342913: Remove calls to doPrivileged in media
• 33987a4: 8342912: Remove calls to doPrivileged in fxml
• d09cb78: 8340852: ScrollPane should not consume navigation keys when it doesn't have direct focus
• 73c85e7: 8342453: Remove calls to doPrivileged in javafx.graphics/com.sun.javafx.tk

Your commit was automatically rebased without conflicts.

[openjdk]

@andy-goryachev-oracle Pushed as commit 6d69084.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.