Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242106: [macos] Remove obsolete GlassView2D.m class #162

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 7, 2020

This is a simple fix to remove some obsolete code. As noted in the JBS description, GlassView2D was made obsolete back in JDK 8, but the GlassView2D.m / .h class files were left in the repo. It is dead code, as there are no references to that class.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242106: [macos] Remove obsolete GlassView2D.m class

Reviewers

  • Ambarish Rapte (arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/162/head:pull/162
$ git checkout pull/162

@kevinrushforth kevinrushforth self-assigned this Apr 7, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 7, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Apr 7, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 7, 2020

@arapte can you review this?

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 7, 2020

Webrevs

@arapte
arapte approved these changes Apr 8, 2020
Copy link
Member

@arapte arapte left a comment

Looks good to me.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242106: [macos] Remove obsolete GlassView2D.m class

Reviewed-by: arapte
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate c154538fab8d9043ae374318ed0eda8c80150b37.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 8, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 8, 2020

/integrate

@openjdk openjdk bot closed this Apr 8, 2020
@openjdk openjdk bot added integrated and removed ready labels Apr 8, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 8, 2020

@kevinrushforth The following commits have been pushed to master since your change was applied:

  • 3f663e3: 8240262: iOS refresh rate is capped to 30 Hz
  • 231879a: 8241710: NullPointerException while entering empty submenu with "arrow right"
  • 470c7d0: 8230809: HTMLEditor formatting lost when selecting all (CTRL-A)

Your commit was automatically rebased without conflicts.

Pushed as commit c154538.

@openjdk openjdk bot removed the rfr label Apr 8, 2020
@kevinrushforth kevinrushforth deleted the kevinrushforth:8242106-rm-GlassView2D branch Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants