-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8242106: [macos] Remove obsolete GlassView2D.m class #162
8242106: [macos] Remove obsolete GlassView2D.m class #162
Conversation
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
@arapte can you review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 4 commits pushed to the ➡️ To integrate this PR with the above commit message, type |
/integrate |
@kevinrushforth The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit c154538. |
This is a simple fix to remove some obsolete code. As noted in the JBS description, GlassView2D was made obsolete back in JDK 8, but the GlassView2D.m / .h class files were left in the repo. It is dead code, as there are no references to that class.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/162/head:pull/162
$ git checkout pull/162