8240694: [macos 10.15] JavaFX Media hangs on some video files on Catalina

[sashamatveev]

https://bugs.openjdk.java.net/browse/JDK-8240694

• Original fix JDK-8236832 was reverted.
• Timestamp will be queried on event loop thread when spectrum event is received by event loop.
• FIx only enabled for macOS when using OSXPlatform.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8240694: [macos 10.15] JavaFX Media hangs on some video files on Catalina

Reviewers

• Kevin Rushforth (kcr - Reviewer)
• Guru Hb (ghb - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/163/head:pull/163
$ git checkout pull/163

[bridgekeeper]

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (0ea46c7)
• 00: Full (b43ace5)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[kevinrushforth]

Can you add a root cause / evaluation either in JBS or to this PR?

I also noted a few places where it might be helpful to add a comment in the code, so anyone looking at it later will know why you are querying the timestamp later from the event thread.

I'll finish my testing in parallel with your addressing those comments and adding the evaluation.

[sashamatveev]

I updated comments in code and added a root cause / evaluation to JBS.

[kevinrushforth]

Looks good.

[guruhb]

Looks good to me, Tested on MacOS 10.12.6 (Sierra) with the use case provided in JBS).

[openjdk]

@sashamatveev This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8240694: [macos 10.15] JavaFX Media hangs on some video files on Catalina

Reviewed-by: kcr, ghb

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 11 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate c154538fab8d9043ae374318ed0eda8c80150b37.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[sashamatveev]

/integrate

[openjdk]

@sashamatveev The following commits have been pushed to master since your change was applied:

• c154538: 8242106: [macos] Remove obsolete GlassView2D.m class
• 3f663e3: 8240262: iOS refresh rate is capped to 30 Hz
• 231879a: 8241710: NullPointerException while entering empty submenu with "arrow right"
• 470c7d0: 8230809: HTMLEditor formatting lost when selecting all (CTRL-A)
• fda015c: 8242167: ios keyboard handling
• 844460b: 8242163: Android keyboard integration fails
• 364c64a: 8241249: NPE in TabPaneSkin.perfromDrag
• 418675a: 8236840: Memory leak when switching ButtonSkin
• 247a65d: 8236971: [macos] Gestures handled incorrectly due to missing events
• 560ef17: 8241455: Memory leak on replacing selection/focusModel
• 5906521: 8241370: Crash in JPEGImageLoader after fix for JDK-8212034

Your commit was automatically rebased without conflicts.

Pushed as commit e1cb191.