Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8223298: SVG patterns are drawn wrong #164

Closed
wants to merge 3 commits into from

Conversation

@arun-Joseph
Copy link
Member

@arun-Joseph arun-Joseph commented Apr 8, 2020

Issue: Assuming the pixelScale is 2, the tile image size is doubled at the native side which is propagated to the java side as well. But, as transform initialization takes place after scaling, the transform is reset to default value.

Fix: Override scale() method in WCBufferedContext class to call init() before scaling.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Guru Hb (ghb - Reviewer)
  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/164/head:pull/164
$ git checkout pull/164

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 8, 2020

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Apr 8, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 8, 2020

Webrevs

@guruhb
guruhb approved these changes Apr 10, 2020
Copy link
Collaborator

@guruhb guruhb left a comment

Looks good to me. Tested on Windows and mac OS X.
If feasible can we have Unit test for this.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 10, 2020

@arun-Joseph This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8223298: SVG patterns are drawn wrong

Reviewed-by: ghb, kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 28 commits pushed to the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e82046ec3b4833f789329809ae521c94cfe5b83e.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@guruhb, @kevinrushforth) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 10, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 15, 2020

As discussed offline, please add a test for this.

@openjdk openjdk bot removed the ready label Apr 15, 2020
@openjdk openjdk bot added the ready label Apr 15, 2020
@guruhb
guruhb approved these changes Apr 17, 2020
Copy link
Collaborator

@guruhb guruhb left a comment

Looks good to me , verified on mac os x and windows.

@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented Apr 17, 2020

/integrate

@openjdk openjdk bot added the sponsor label Apr 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 17, 2020

@arun-Joseph
Your change (at version 8667465) is now ready to be sponsored by a Committer.

@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented Apr 17, 2020

/integrate

@openjdk openjdk bot closed this Apr 17, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 17, 2020

@arun-Joseph The following commits have been pushed to master since your change was applied:

  • e82046e: 8242530: [macos] Some audio files miss spectrum data when another audio file plays first
  • 7044cef: 8241476: Linux build warnings issued on gcc 9
  • 9d50c4c: Merge
  • 4d69a0d: 8241629: [macos10.15] Long startup delay playing media over https on Catalina
  • b1fdc45: 8242209: Increase web native thread stack size for x86 mode
  • e1cb191: 8240694: [macos 10.15] JavaFX Media hangs on some video files on Catalina
  • c154538: 8242106: [macos] Remove obsolete GlassView2D.m class
  • 3f663e3: 8240262: iOS refresh rate is capped to 30 Hz
  • 231879a: 8241710: NullPointerException while entering empty submenu with "arrow right"
  • 470c7d0: 8230809: HTMLEditor formatting lost when selecting all (CTRL-A)
  • fda015c: 8242167: ios keyboard handling
  • 844460b: 8242163: Android keyboard integration fails
  • 364c64a: 8241249: NPE in TabPaneSkin.perfromDrag
  • 418675a: 8236840: Memory leak when switching ButtonSkin
  • 247a65d: 8236971: [macos] Gestures handled incorrectly due to missing events
  • 560ef17: 8241455: Memory leak on replacing selection/focusModel
  • ef37669: Merge
  • f2bca9f: Merge
  • 6900d29: Merge
  • e91bec4: Merge
  • 66a8f49: Merge
  • fde42da: Merge
  • e21fd1f: Merge
  • 443c845: Merge
  • 31e63de: Merge
  • 14c6938: 8236798: Enhance FX scripting support
  • bfb2d0e: Merge
  • 39f6127: Merge

Your commit was automatically rebased without conflicts.

Pushed as commit ec8608f.

@arun-Joseph arun-Joseph deleted the arun-Joseph:8223298 branch Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants