Skip to content

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jan 29, 2025

Clean backport of macOS 15 activation fix to the jfx24 stabilization branch.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8348744: Application window not always activated on macOS 15 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1687/head:pull/1687
$ git checkout pull/1687

Update a local copy of the PR:
$ git checkout pull/1687
$ git pull https://git.openjdk.org/jfx.git pull/1687/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1687

View PR using the GUI difftool:
$ git pr show -t 1687

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1687.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 29, 2025

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into jfx24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 29, 2025

@kevinrushforth This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348744: Application window not always activated on macOS 15

Reviewed-by: angorya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx24 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx24 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport f55f5c609f67c1f7a8b8107d6ab1c6945fc44506 8348744: Application window not always activated on macOS 15 Jan 29, 2025
@openjdk
Copy link

openjdk bot commented Jan 29, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Ready for review labels Jan 29, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 29, 2025

Webrevs

@kevinrushforth
Copy link
Member Author

@jperedadnr or @andy-goryachev-oracle can one of you review this clean backport?

Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk openjdk bot added the ready Ready to be integrated label Jan 29, 2025
@kevinrushforth
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 29, 2025

Going to push as commit 0f540e2.
Since your change was applied there has been 1 commit pushed to the jfx24 branch:

  • 7f3e320: 8348736: RichTextArea clamp and getText

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 29, 2025
@openjdk openjdk bot closed this Jan 29, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jan 29, 2025
@openjdk
Copy link

openjdk bot commented Jan 29, 2025

@kevinrushforth Pushed as commit 0f540e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants