-
Notifications
You must be signed in to change notification settings - Fork 562
8348895: [testbug] Skip failing 3D lighting tests on macOS 14 or later on aarch64 #1689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8348895: [testbug] Skip failing 3D lighting tests on macOS 14 or later on aarch64 #1689
Conversation
|
👋 Welcome back kcr! A progress list of the required criteria for merging this PR into |
|
@kevinrushforth This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
Reviewer: @arapte |
|
/integrate |
|
@kevinrushforth Pushed as commit e079ed3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport to the
jfx24stabilization branch of test fix to exclude lighting tests on macOS 14+ (aarch64)Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1689/head:pull/1689$ git checkout pull/1689Update a local copy of the PR:
$ git checkout pull/1689$ git pull https://git.openjdk.org/jfx.git pull/1689/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1689View PR using the GUI difftool:
$ git pr show -t 1689Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1689.diff
Using Webrev
Link to Webrev Comment