Skip to content

Conversation

@andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Mar 18, 2025

Fixes embarrassing bugs in Rich Editor Demo:

  • File -> Save not saving
  • File -> Open not emphasizing .rich files

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8352268: RichEditorDemo: Save file doesn't always save (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1739/head:pull/1739
$ git checkout pull/1739

Update a local copy of the PR:
$ git checkout pull/1739
$ git pull https://git.openjdk.org/jfx.git pull/1739/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1739

View PR using the GUI difftool:
$ git pr show -t 1739

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1739.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 18, 2025

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 18, 2025

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352268: RichEditorDemo: Save file doesn't always save

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 0e50961: 8351038: ConcurrentModificationException in EventType constructor

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@andy-goryachev-oracle andy-goryachev-oracle marked this pull request as ready for review March 18, 2025 21:48
@openjdk openjdk bot added the rfr Ready for review label Mar 18, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 18, 2025

Webrevs

@andy-goryachev-oracle andy-goryachev-oracle changed the title 8352268: [TestBug] Saving in Rich Editor Demo 8352268: RichEditorDemo: Save file doesn't always save Mar 19, 2025
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tried the work flow that failed for me earlier and it now works.

@openjdk openjdk bot added the ready Ready to be integrated label Mar 19, 2025
@andy-goryachev-oracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 19, 2025

Going to push as commit 0eda4df.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 0e50961: 8351038: ConcurrentModificationException in EventType constructor

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 19, 2025
@openjdk openjdk bot closed this Mar 19, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Mar 19, 2025
@openjdk
Copy link

openjdk bot commented Mar 19, 2025

@andy-goryachev-oracle Pushed as commit 0eda4df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@andy-goryachev-oracle andy-goryachev-oracle deleted the 8352268.save branch March 19, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants