Skip to content

8340004: [TestBug] Call ModuleLayer.Controller::enableNativeAccess directly rather than via reflection #1743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Ziad-Mid
Copy link
Contributor

@Ziad-Mid Ziad-Mid commented Mar 25, 2025

With the minimum JDK set to 22, the reflection calls is replaced with direct calls to enableNativeAccess


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340004: [TestBug] Call ModuleLayer.Controller::enableNativeAccess directly rather than via reflection (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1743/head:pull/1743
$ git checkout pull/1743

Update a local copy of the PR:
$ git checkout pull/1743
$ git pull https://git.openjdk.org/jfx.git pull/1743/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1743

View PR using the GUI difftool:
$ git pr show -t 1743

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1743.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 25, 2025

👋 Welcome back zelmidaoui! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 25, 2025

@Ziad-Mid This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340004: [TestBug] Call ModuleLayer.Controller::enableNativeAccess directly rather than via reflection

Reviewed-by: angorya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 9143377: 8342565: [TestBug] StubTextLayout
  • a550e5e: 8350149: VBox ignores bias of child controls when fillWidth is set to false

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@andy-goryachev-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Ready for review label Mar 25, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 25, 2025

Webrevs

Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

please update the copyright year in the modified files.
1 reviewer is probably enough.

@Ziad-Mid
Copy link
Contributor Author

looks good!

please update the copyright year in the modified files. 1 reviewer is probably enough.

Done,
Can I integrate ?

@openjdk openjdk bot added the ready Ready to be integrated label Mar 28, 2025
@Ziad-Mid
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Mar 28, 2025
@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@Ziad-Mid
Your change (at version e73d931) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

Going to push as commit ff777c7.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 9143377: 8342565: [TestBug] StubTextLayout
  • a550e5e: 8350149: VBox ignores bias of child controls when fillWidth is set to false

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 28, 2025
@openjdk openjdk bot closed this Mar 28, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Mar 28, 2025
@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@kevinrushforth @Ziad-Mid Pushed as commit ff777c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Ziad-Mid Ziad-Mid deleted the 8340004.ModuleLayer branch May 27, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants