8352746: [TestBug] Monkey Tester Application Update 5

[andy-goryachev-oracle]

Further additions to the MonkeyTester application:

• platform preferences monitor
• improved pages: hbox, vbox
• improved css playground
• mouse listener option in some context menus
• additional choices: background
• additional properties: Node::clip, Region::shape, TextInputControl::textFormatter
• font selector in Tools -> JTextArea/JTextField Embedded in SwingNode

New Pages

• anchor pane
• border pane
• button bar
• flow pane
• grid pane
• media player
• progress indicator
• separator
• slider
• stack pane
• stage
• tile pane

Properties Monitor

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8352746: [TestBug] Monkey Tester Application Update 5 (Enhancement - P4)

Reviewers

• Lukasz Kostyra (@lukostyra - Reviewer)
• Jayathirth D V (@jayathirthrao - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1750/head:pull/1750
$ git checkout pull/1750

Update a local copy of the PR:
$ git checkout pull/1750
$ git pull https://git.openjdk.org/jfx.git pull/1750/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1750

View PR using the GUI difftool:
$ git pr show -t 1750

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1750.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@andy-goryachev-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8352746: [TestBug] Monkey Tester Application Update 5

Reviewed-by: lkostyra, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 5d41364: 8353557: Skip some system tests on Linux
• 76282bc: 8353587: Spelling errors and dead code
• 714f17f: 8353668: Rename internal c.s.javafx.text.TextLine class
• 62f94bb: 8353620: Make some systems tests robust for Ubuntu 24.04
• 1a65f4c: 8353617: Remove deprecated TransitionEvent constructor
• 9ab2036: 8353548: [macOS] DragEvent.getScreenY() returns incorrect value in secondary monitor
• c0db2dc: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths
• ab94b5e: 8351276: Prevent redundant computeValue calls when a chain of mappings becomes observed
• 097c017: 8245602: Ensemble8: HTMLEditor Toolbar gets scrolled out of view
• 4a4272b: 8350976: MenuBarSkin: exception initializing in a background thread
• ... and 4 more: https://git.openjdk.org/jfx/compare/ff777c7abb0f491152d172f20cfc3dd6d76d5339...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[andy-goryachev-oracle]

/reviewers 2

[openjdk]

@andy-goryachev-oracle
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[mlbridge]

Webrevs

• 00: Full (4474f46f)

[kevinrushforth]

Reviewers: @lukostyra @jayathirthrao

[lukostyra]

LGTM.

Since this is a test app, I did only a brief look-through the code, I ran it and played around with new test examples. All seems to run quite well on Windows.

[jayathirthrao]

Looks good to me.
Played around with newly added features and everything works fine in my macOS 14.7.4 system.

[jayathirthrao]

I used the README to build and run this app.
Suggestion for future updates:
In this command we should not add "javafx-sdk-24" in the path.
JAVAFX already includes sdk folder we just need to use java -p <JAVAFX>/lib/ --add-modules ALL-MODULE-PATH -jar MonkeyTester.jar

[andy-goryachev-oracle]

good point, thanks!

Created https://bugs.openjdk.org/browse/JDK-8353743

[andy-goryachev-oracle]

/integrate

[openjdk]

Going to push as commit a52e2fa.
Since your change was applied there have been 14 commits pushed to the master branch:

• 5d41364: 8353557: Skip some system tests on Linux
• 76282bc: 8353587: Spelling errors and dead code
• 714f17f: 8353668: Rename internal c.s.javafx.text.TextLine class
• 62f94bb: 8353620: Make some systems tests robust for Ubuntu 24.04
• 1a65f4c: 8353617: Remove deprecated TransitionEvent constructor
• 9ab2036: 8353548: [macOS] DragEvent.getScreenY() returns incorrect value in secondary monitor
• c0db2dc: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths
• ab94b5e: 8351276: Prevent redundant computeValue calls when a chain of mappings becomes observed
• 097c017: 8245602: Ensemble8: HTMLEditor Toolbar gets scrolled out of view
• 4a4272b: 8350976: MenuBarSkin: exception initializing in a background thread
• ... and 4 more: https://git.openjdk.org/jfx/compare/ff777c7abb0f491152d172f20cfc3dd6d76d5339...master

Your commit was automatically rebased without conflicts.

[openjdk]

@andy-goryachev-oracle Pushed as commit a52e2fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.