8245602: Ensemble8: HTMLEditor Toolbar gets scrolled out of view

[Gopalora]

There was a scrolling issue with multiline edit control with text controls at the top of the edit box JDK-8245602,

We replaced the ScrollPane with VBox control as the parent of the html edit control.

Verification:
This makes the controls on the top of the edit control, And the texts scroll inside the text area as expected.
Similar kind of behavior is seen in normal web pages with multiline edit controls inside it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8245602: Ensemble8: HTMLEditor Toolbar gets scrolled out of view (Bug - P4)

Reviewers

• Andy Goryachev (@andy-goryachev-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1752/head:pull/1752
$ git checkout pull/1752

Update a local copy of the PR:
$ git checkout pull/1752
$ git pull https://git.openjdk.org/jfx.git pull/1752/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1752

View PR using the GUI difftool:
$ git pr show -t 1752

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1752.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back Gopalora! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Gopalora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8245602: Ensemble8: HTMLEditor Toolbar gets scrolled out of view

Reviewed-by: angorya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 4a4272b: 8350976: MenuBarSkin: exception initializing in a background thread
• 056c7f5: 8350009: [XWayland] SwingNodePlatformExitCrashTest hangs on Ubuntu 24.04
• c452189: 8351733: Crash when creating too many nested event loops
• cc949cd: 8351047: TitledPane should handle titles that are resizable
• 5c78234: 8281384: Random chars on paste from Windows clipboard

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@andy-goryachev-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (cbbcfb03)

[kevinrushforth]

Reviewer: @arapte or @andy-goryachev-oracle

[andy-goryachev-oracle]

I'll take a look.

[andy-goryachev-oracle]

the change fixes the issue at hand.

[andy-goryachev-oracle]

A general comment (tangentially related to the issue): the layout could be better in utilizing the available space:

[andy-goryachev-oracle]

This fix is simple enough, 1 reviewer is probably sufficient.

[Gopalora]

/integrate

[openjdk]

@Gopalora
Your change (at version cbbcfb0) is now ready to be sponsored by a Committer.

[andy-goryachev-oracle]

/sponsor

[openjdk]

Going to push as commit 097c017.
Since your change was applied there have been 5 commits pushed to the master branch:

• 4a4272b: 8350976: MenuBarSkin: exception initializing in a background thread
• 056c7f5: 8350009: [XWayland] SwingNodePlatformExitCrashTest hangs on Ubuntu 24.04
• c452189: 8351733: Crash when creating too many nested event loops
• cc949cd: 8351047: TitledPane should handle titles that are resizable
• 5c78234: 8281384: Random chars on paste from Windows clipboard

Your commit was automatically rebased without conflicts.

[openjdk]

@andy-goryachev-oracle @Gopalora Pushed as commit 097c017.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.