-
Notifications
You must be signed in to change notification settings - Fork 541
8353617: Remove deprecated TransitionEvent constructor #1758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into |
|
@mstr2 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
@mstr2 has indicated that a compatibility and specification (CSR) request is needed for this pull request. @mstr2 please create a CSR request for issue JDK-8353617 with the correct fix version. This pull request cannot be integrated until the CSR request is approved. |
|
Since this needs a CSR, a second reviewer is best. I'll do that, since I want to review the CSR anyway. /reviewers 2 |
|
@kevinrushforth |
|
@mstr2 I reviewed the CSR, so you can Finalize it at your convenience. |
andy-goryachev-oracle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a "virtual particle": briefly came into existence then disappeared, contributing to mass when it existed.
|
/integrate |
|
Going to push as commit 1a65f4c.
Your commit was automatically rebased without conflicts. |
Remove the deprecated
TransitionEvent(EventType, StyleableProperty, Duration)constructor.A single reviewer should be sufficient.
/csr
Progress
Issues
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1758/head:pull/1758$ git checkout pull/1758Update a local copy of the PR:
$ git checkout pull/1758$ git pull https://git.openjdk.org/jfx.git pull/1758/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1758View PR using the GUI difftool:
$ git pr show -t 1758Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1758.diff
Using Webrev
Link to Webrev Comment