Skip to content

Conversation

@mstr2
Copy link
Collaborator

@mstr2 mstr2 commented Apr 3, 2025

Remove the deprecated TransitionEvent(EventType, StyleableProperty, Duration) constructor.

A single reviewer should be sufficient.

/csr


Progress

  • Change requires CSR request JDK-8353618 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issues

  • JDK-8353617: Remove deprecated TransitionEvent constructor (Enhancement - P4)
  • JDK-8353618: Remove deprecated TransitionEvent constructor (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1758/head:pull/1758
$ git checkout pull/1758

Update a local copy of the PR:
$ git checkout pull/1758
$ git pull https://git.openjdk.org/jfx.git pull/1758/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1758

View PR using the GUI difftool:
$ git pr show -t 1758

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1758.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 3, 2025

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 3, 2025

@mstr2 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8353617: Remove deprecated TransitionEvent constructor

Reviewed-by: jhendrikx, kcr, angorya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 9ab2036: 8353548: [macOS] DragEvent.getScreenY() returns incorrect value in secondary monitor
  • c0db2dc: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths
  • ab94b5e: 8351276: Prevent redundant computeValue calls when a chain of mappings becomes observed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added rfr Ready for review csr Need approved CSR to integrate pull request labels Apr 3, 2025
@openjdk
Copy link

openjdk bot commented Apr 3, 2025

@mstr2 has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@mstr2 please create a CSR request for issue JDK-8353617 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@mlbridge
Copy link

mlbridge bot commented Apr 3, 2025

Webrevs

@kevinrushforth
Copy link
Member

Since this needs a CSR, a second reviewer is best. I'll do that, since I want to review the CSR anyway.

/reviewers 2

@openjdk
Copy link

openjdk bot commented Apr 3, 2025

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

@kevinrushforth
Copy link
Member

@mstr2 I reviewed the CSR, so you can Finalize it at your convenience.

Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a "virtual particle": briefly came into existence then disappeared, contributing to mass when it existed.

@openjdk openjdk bot added ready Ready to be integrated and removed csr Need approved CSR to integrate pull request labels Apr 3, 2025
@mstr2
Copy link
Collaborator Author

mstr2 commented Apr 3, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Apr 3, 2025

Going to push as commit 1a65f4c.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 9ab2036: 8353548: [macOS] DragEvent.getScreenY() returns incorrect value in secondary monitor
  • c0db2dc: 8352982: gradle TEST_SDK_PATH param doesn't work with relative paths
  • ab94b5e: 8351276: Prevent redundant computeValue calls when a chain of mappings becomes observed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 3, 2025
@openjdk openjdk bot closed this Apr 3, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Apr 3, 2025
@openjdk
Copy link

openjdk bot commented Apr 3, 2025

@mstr2 Pushed as commit 1a65f4c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mstr2 mstr2 deleted the feature/remove-transitionevent-ctor branch July 26, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants