Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242490: Upgrade to gcc 9.2 on Linux #178

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 13, 2020

This is a compiler upgrade on Linux from the current gcc 8.3 compiler to gcc 9.2. This will match a recent upgrade done for JDK 15 -- see JDK-8241721.

On a related note, using the gcc 9 compiler produces many (harmless) warnings that will be addressed by JDK-8241476 -- see PR #150.

I have run a full build and test using this new compiler.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Ambarish Rapte (arapte - Reviewer)
  • Johan Vos (jvos - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/178/head:pull/178
$ git checkout pull/178

@kevinrushforth kevinrushforth requested a review from johanvos Apr 13, 2020
@kevinrushforth kevinrushforth self-assigned this Apr 13, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 13, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 13, 2020

/reviewers 2

@openjdk openjdk bot added the rfr label Apr 13, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 13, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 13, 2020

@arapte can you also review this?

@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 13, 2020

Webrevs

@arapte
arapte approved these changes Apr 14, 2020
Copy link
Collaborator

@johanvos johanvos left a comment

Works on my development system (didn't test on our build system yet)

@openjdk
Copy link

@openjdk openjdk bot commented Apr 18, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242490: Upgrade to gcc 9.2 on Linux

Reviewed-by: arapte, jvos
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 22 commits pushed to the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate dedf7cb73a012e74b098cc49330bc00c20b97bac.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 18, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 18, 2020

I won't integrate this until Monday anyway. If you run into a problem with the actual builds using this compiler, let me know and I'll hold off further (it's been well-tested on my end).

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 20, 2020

/integrate

@openjdk openjdk bot closed this Apr 20, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 20, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 20, 2020

@kevinrushforth The following commits have been pushed to master since your change was applied:

  • 5e9fb82: 8242577: Cell selection fails on iOS most of the times
  • 69e4266: 8242489: ChoiceBox: initially toggle not sync'ed to selection
  • 1d88180: 8243112: Skip failing test SVGTest.testSVGRenderingWithPattern
  • ec8608f: 8223298: SVG patterns are drawn wrong
  • e82046e: 8242530: [macos] Some audio files miss spectrum data when another audio file plays first
  • 7044cef: 8241476: Linux build warnings issued on gcc 9
  • 9d50c4c: Merge
  • 4d69a0d: 8241629: [macos10.15] Long startup delay playing media over https on Catalina
  • b1fdc45: 8242209: Increase web native thread stack size for x86 mode
  • ef37669: Merge
  • f2bca9f: Merge
  • 6900d29: Merge
  • e91bec4: Merge
  • 66a8f49: Merge
  • fde42da: Merge
  • e21fd1f: Merge
  • 443c845: Merge
  • 31e63de: Merge
  • 14c6938: 8236798: Enhance FX scripting support
  • bfb2d0e: Merge
  • 39f6127: Merge

Your commit was automatically rebased without conflicts.

Pushed as commit dedf7cb.

@kevinrushforth kevinrushforth deleted the kevinrushforth:8242490-gcc-9.2 branch Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants