Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8241629: [macos10.15] Long startup delay playing media over https on Catalina #179

Closed
wants to merge 1 commit into from

Conversation

sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Apr 13, 2020

https://bugs.openjdk.java.net/browse/JDK-8241629

We used to link with system provided libffi (due to a bug in Makefile) and for some reason GLib signals did not work correctly and thus we did not able to build dynamic pipelines. We did not switch to AVFoundation until timeout is reached while waiting for GStreamer to start playing or report us an error. Fixed by linking GLib with libffi which we build, like we do for other platforms.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8241629: [macos10.15] Long startup delay playing media over https on Catalina

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/179/head:pull/179
$ git checkout pull/179

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 13, 2020

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@sashamatveev sashamatveev changed the title [macos10.15] Long startup delay playing media over https on Catalina 8241629: [macos10.15] Long startup delay playing media over https on Catalina Apr 13, 2020
@openjdk openjdk bot added the rfr label Apr 13, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 14, 2020

Webrevs

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Looks good. I tested it on both 10.15.x (Catalina) and 10.13.x (High Sierra). I confirm that there is no more dependency on the system libffi.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 14, 2020

@sashamatveev This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8241629: [macos10.15] Long startup delay playing media over https on Catalina

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b1fdc45f01ce7374fecf4705867fdb4baf6142a2.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 14, 2020
@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented Apr 14, 2020

/integrate

@openjdk openjdk bot closed this Apr 14, 2020
@openjdk openjdk bot added integrated and removed ready labels Apr 14, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 14, 2020

@sashamatveev The following commits have been pushed to master since your change was applied:

  • b1fdc45: 8242209: Increase web native thread stack size for x86 mode

Your commit was automatically rebased without conflicts.

Pushed as commit 4d69a0d.

@openjdk openjdk bot removed the rfr label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants