8356690: Update JUnit to 5.12.2

[Maran23]

This PR bumps the JUnit version to 5.12.2.
Also removed 2 now unused variables since I phased out the JUnit Vintage Engine + Hamcrest.

Changelog: https://junit.org/junit5/docs/current/release-notes/index.html#release-notes-5.12.2
The mentioned deprecations do not affect us.

Interesting new features:

• Thread dumps on test timeouts
• Parameterized test validation improvements
• JRE-based conditions such as @EnabledOnJre and @DisabledForJreRange now support arbitrary Java versions

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8356690: Update JUnit to 5.12.2 (Bug - P4)

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Ambarish Rapte (@arapte - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1803/head:pull/1803
$ git checkout pull/1803

Update a local copy of the PR:
$ git checkout pull/1803
$ git pull https://git.openjdk.org/jfx.git pull/1803/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1803

View PR using the GUI difftool:
$ git pr show -t 1803

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1803.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mhanl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@Maran23 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8356690: Update JUnit to 5.12.2

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• ce0b9e8: 8238435: [macOs] Remove use of CGEventTap
• 3299949: 8342530: Specifying "@nx" scaling level in ImageStorage should only load that specific level
• 5b659f5: 8354631: [macos] OpenURIHandler events not received by AWT when JavaFX is primary toolkit
• ... and 4 more: https://git.openjdk.org/jfx/compare/bffc32bfef9b48478382180beefdb84f2b8651c6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (3d3f6ca6)

[kevinrushforth]

I'll review this. I need to upload the new binaries to our build server and do a CI test run.

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

The changes look good. A local build works. I fired off a test build on our CI server and will approve once it completes with no errors.

[kevinrushforth]

All good.

[kevinrushforth]

@arapte can you be the second reviewer?

[arapte]

lgtm

[Maran23]

/integrate

[openjdk]

Going to push as commit a14c2b3.
Since your change was applied there have been 8 commits pushed to the master branch:

• 9ca61ed: 8355415: RichTextArea: NPE in VFlow::scrollCaretToVisible
• ce0b9e8: 8238435: [macOs] Remove use of CGEventTap
• 3299949: 8342530: Specifying "@nx" scaling level in ImageStorage should only load that specific level
• ... and 5 more: https://git.openjdk.org/jfx/compare/bffc32bfef9b48478382180beefdb84f2b8651c6...master

Your commit was automatically rebased without conflicts.

[openjdk]

@Maran23 Pushed as commit a14c2b3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.