Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242577: Cell selection fails on iOS most of the times #181

wants to merge 1 commit into from


Copy link

@jperedadnr jperedadnr commented Apr 14, 2020

There are cases when iOS sends one or more NSTouchPhaseMoved for a given touch event, in between NSTouchPhaseBegan and NSTouchPhaseEnded , even if the initial event location didn't change.

By default, all these events are emulated as mouse enter/down, drag and up/exit events.

However, when the user taps quickly or even holds steady on a cell, if these touch moved events are generated and sent as mouse drag events, the cell selection fails, as the flag latePress used in CellBehaviorBase is set to false, preventing the cell selection that should happen upon touch release event.

This PR prevents emulating mouse drag events when the touch event doesn't change its location.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed


  • JDK-8242577: Cell selection fails on iOS most of the times


  • Johan Vos (jvos - Reviewer)


$ git fetch pull/181/head:pull/181
$ git checkout pull/181

Copy link

bridgekeeper bot commented Apr 14, 2020

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr Ready for review label Apr 14, 2020
Copy link

mlbridge bot commented Apr 14, 2020


Copy link

@johanvos johanvos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

Copy link

openjdk bot commented Apr 16, 2020

@jperedadnr This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242577: Cell selection fails on iOS most of the times

Reviewed-by: jvos
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 19 commits pushed to the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 5e9fb8294770f40b9ee1e6e703e07c9d50310694.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@johanvos) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Ready to be integrated label Apr 16, 2020
Copy link
Collaborator Author


@openjdk openjdk bot added the sponsor Ready to sponsor label Apr 17, 2020
Copy link

openjdk bot commented Apr 17, 2020

Your change (at version e385b39) is now ready to be sponsored by a Committer.

Copy link


@openjdk openjdk bot closed this Apr 20, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Ready to sponsor ready Ready to be integrated labels Apr 20, 2020
Copy link

openjdk bot commented Apr 20, 2020

@johanvos @jperedadnr The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.

Pushed as commit 5e9fb82.

@openjdk openjdk bot removed the rfr Ready for review label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
integrated Pull request has been integrated
2 participants