8242577: Cell selection fails on iOS most of the times

[jperedadnr]

There are cases when iOS sends one or more NSTouchPhaseMoved for a given touch event, in between NSTouchPhaseBegan and NSTouchPhaseEnded , even if the initial event location didn't change.

By default, all these events are emulated as mouse enter/down, drag and up/exit events.

However, when the user taps quickly or even holds steady on a cell, if these touch moved events are generated and sent as mouse drag events, the cell selection fails, as the flag latePress used in CellBehaviorBase is set to false, preventing the cell selection that should happen upon touch release event.

This PR prevents emulating mouse drag events when the touch event doesn't change its location.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8242577: Cell selection fails on iOS most of the times

Reviewers

• Johan Vos (jvos - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/181/head:pull/181
$ git checkout pull/181

[bridgekeeper]

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 00: Full (e385b39)

[johanvos]

looks good.

[openjdk]

@jperedadnr This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242577: Cell selection fails on iOS most of the times

Reviewed-by: jvos

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 19 commits pushed to the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 5e9fb8294770f40b9ee1e6e703e07c9d50310694.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@johanvos) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jperedadnr]

/integrate

[openjdk]

@jperedadnr
Your change (at version e385b39) is now ready to be sponsored by a Committer.

[johanvos]

/sponsor

[openjdk]

@johanvos @jperedadnr The following commits have been pushed to master since your change was applied:

• 69e4266: 8242489: ChoiceBox: initially toggle not sync'ed to selection
• 1d88180: 8243112: Skip failing test SVGTest.testSVGRenderingWithPattern
• ec8608f: 8223298: SVG patterns are drawn wrong
• e82046e: 8242530: [macos] Some audio files miss spectrum data when another audio file plays first
• 7044cef: 8241476: Linux build warnings issued on gcc 9
• 9d50c4c: Merge
• ef37669: Merge
• f2bca9f: Merge
• 6900d29: Merge
• e91bec4: Merge
• 66a8f49: Merge
• fde42da: Merge
• e21fd1f: Merge
• 443c845: Merge
• 31e63de: Merge
• 14c6938: 8236798: Enhance FX scripting support
• bfb2d0e: Merge
• 39f6127: Merge

Your commit was automatically rebased without conflicts.

Pushed as commit 5e9fb82.