-
Notifications
You must be signed in to change notification settings - Fork 543
8358454: Wrong <br> tags in cssref.html #1820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into |
|
@mstr2 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
| <h3><a id="typeeasingfunction"><easing-function></a></h3> | ||
| <p class="grammar">linear | <cubic-bezier-easing-function> | <step-easing-function> | <fx-easing-function></p> | ||
| <p><strong>Linear</strong> <span class="grammar" style="font-size: smaller;">linear</span><br/> | ||
| <p><strong>Linear</strong> <span class="grammar" style="font-size: smaller;">linear</span><br> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is Linear looks like plain linear but Cubic Bézier Easing Functions has triangular brackets <cubic-bezier-easing-function>?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
linear is a concrete value, whereas <cubic-bezier-easing-function> is defined later to be one of five possible concrete values.
| <td style="width: 120px; vertical-align: top"><span class="grammar">steps</span></td> | ||
| <td>defines a step function with <a href="#typenumber" class="typelink"><integer></a> intervals | ||
| and an optional <span class="grammar"><step-position></span>;<br/>if omitted, | ||
| and an optional <span class="grammar"><step-position></span>;<br>if omitted, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
possible future enhancement: add thin grid lines to the tables, similar to other tables.
andy-goryachev-oracle
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left minor comments, otherwise looks good.
|
minor doc changes, a single reviewer is probably sufficient. |
|
/integrate |
Some
<br>tags in cssref.html are written as<br/>or</br>. It should be<br>, since it is a void element.A single reviewer is sufficient.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1820/head:pull/1820$ git checkout pull/1820Update a local copy of the PR:
$ git checkout pull/1820$ git pull https://git.openjdk.org/jfx.git pull/1820/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1820View PR using the GUI difftool:
$ git pr show -t 1820Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1820.diff
Using Webrev
Link to Webrev Comment