Skip to content

Conversation

@mstr2
Copy link
Collaborator

@mstr2 mstr2 commented Jun 3, 2025

Some <br> tags in cssref.html are written as <br/> or </br>. It should be <br>, since it is a void element.

A single reviewer is sufficient.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8358454: Wrong <br> tags in cssref.html (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1820/head:pull/1820
$ git checkout pull/1820

Update a local copy of the PR:
$ git checkout pull/1820
$ git pull https://git.openjdk.org/jfx.git pull/1820/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1820

View PR using the GUI difftool:
$ git pr show -t 1820

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1820.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2025

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 3, 2025

@mstr2 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358454: Wrong <br> tags in cssref.html

Reviewed-by: angorya, jhendrikx

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Ready for review label Jun 3, 2025
@mlbridge
Copy link

mlbridge bot commented Jun 3, 2025

Webrevs

<h3><a id="typeeasingfunction">&lt;easing-function&gt;</a></h3>
<p class="grammar">linear | &lt;cubic-bezier-easing-function&gt; | &lt;step-easing-function&gt; | &lt;fx-easing-function&gt;</p>
<p><strong>Linear</strong> <span class="grammar" style="font-size: smaller;">linear</span><br/>
<p><strong>Linear</strong> <span class="grammar" style="font-size: smaller;">linear</span><br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is Linear looks like plain linear but Cubic Bézier Easing Functions has triangular brackets <cubic-bezier-easing-function>?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linear is a concrete value, whereas <cubic-bezier-easing-function> is defined later to be one of five possible concrete values.

<td style="width: 120px; vertical-align: top"><span class="grammar">steps</span></td>
<td>defines a step function with <a href="#typenumber" class="typelink">&lt;integer&gt;</a> intervals
and an optional <span class="grammar">&lt;step-position&gt;</span>;<br/>if omitted,
and an optional <span class="grammar">&lt;step-position&gt;</span>;<br>if omitted,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

possible future enhancement: add thin grid lines to the tables, similar to other tables.

Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left minor comments, otherwise looks good.

@andy-goryachev-oracle
Copy link
Contributor

minor doc changes, a single reviewer is probably sufficient.

@openjdk openjdk bot added the ready Ready to be integrated label Jun 3, 2025
@mstr2
Copy link
Collaborator Author

mstr2 commented Jun 3, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jun 3, 2025

Going to push as commit fdd50d8.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 9edc169: 8358255: Factor out boilerplate code of EventHandler properties in Scene and Window

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 3, 2025
@openjdk openjdk bot closed this Jun 3, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jun 3, 2025
@openjdk
Copy link

openjdk bot commented Jun 3, 2025

@mstr2 Pushed as commit fdd50d8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mstr2 mstr2 deleted the fixes/cssref-br-tags branch June 7, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants