Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242637: Change JavaFX release version in jfx14 branch to 14.0.1 #183

Closed
wants to merge 1 commit into from

Conversation

@johanvos
Copy link
Collaborator

@johanvos johanvos commented Apr 14, 2020

Fix for JDK-8242637


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242637: Change JavaFX release version in jfx14 branch to 14.0.1

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/183/head:pull/183
$ git checkout pull/183

Fix for JDK-8242637
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 14, 2020

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into jfx14 will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Apr 14, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 14, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 14, 2020

@johanvos This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242637: Change JavaFX release version in jfx14 branch to 14.0.1

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 9 commits pushed to the jfx14 branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge jfx14 into your branch, and then specify the current head hash when integrating, like this: /integrate a2369b1ca1cd11c922756967309d3377e56c2d3f.

➡️ To integrate this PR with the above commit message to the jfx14 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 14, 2020
@johanvos
Copy link
Collaborator Author

@johanvos johanvos commented Apr 15, 2020

/integrate

@openjdk openjdk bot closed this Apr 15, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 15, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2020

@johanvos The following commits have been pushed to jfx14 since your change was applied:

  • 2b8cb38: 8236798: Enhance FX scripting support
  • e51f5d5: 8240832: Remove unused applecoreaudio.md third-party legal file
  • 1b3905d: 8240211: Stack overflow on Windows 32-bit can lead to crash
  • 33f2278: 8239109: Update SQLite to version 3.31.1
  • cf47a95: 8239454: LLIntData : invalid opcode returned for 16 and 32 bit wide instructions
  • a56d1ff: 8238526: Cherry pick GTK WebKit 2.26.3 changes
  • 507683d: 8237003: Remove hardcoded WebAnimationsCSSIntegrationEnabled flag in DumpRenderTree
  • d24e31b: 8233942: Update to 609.1 version of WebKit

Your commit was automatically rebased without conflicts.

Pushed as commit a2369b1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants