8357714: AudioClip.play crash on macOS when loading resource from jar by johanvos · Pull Request #1839 · openjdk/jfx

johanvos · 2025-07-02T21:47:05Z

After JDK-8287822 (https://bugs.openjdk.org/browse/JDK-8287822), mpeg file content is no longer played via GSTPlatform but via OSXPlatform.
We need to correctly handle data in case the source is a file inside a jar, in which case CJavaInputStreamCallbacks is used.

The 2 changes I made are:

Use ConnectionHolder instead of Locator for CJavaInputStreamCallbacks in case a jar resource is used.
In case of random access datasource, use readBlock instead of readNextBlock in AVMediaPlayer

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

JDK-8357714: AudioClip.play crash on macOS when loading resource from jar (Bug - P3)

Reviewers

Andy Goryachev (@andy-goryachev-oracle - Reviewer)
Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1839/head:pull/1839
$ git checkout pull/1839

Update a local copy of the PR:
$ git checkout pull/1839
$ git pull https://git.openjdk.org/jfx.git pull/1839/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1839

View PR using the GUI difftool:
$ git pr show -t 1839

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1839.diff

Using Webrev

Link to Webrev Comment

In case of random access datasource, use readBlock instead of readNextBlock

bridgekeeper · 2025-07-02T21:47:41Z

👋 Welcome back jvos! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-07-02T21:47:51Z

@johanvos This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357714: AudioClip.play crash on macOS when loading resource from jar

Reviewed-by: angorya, almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

6029e3e: 8359387: Bump minimum JDK version for JavaFX to JDK 23
639a595: 8357584: [XWayland] [OL10] Robot.mousePress() is delivered to wrong place

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

mlbridge · 2025-07-02T21:51:25Z

Webrevs

johanvos · 2025-07-03T07:20:26Z

@sashamatveev can you review this?

andy-goryachev-oracle · 2025-07-03T14:34:28Z

/reviewers 2

openjdk · 2025-07-03T14:35:35Z

@andy-goryachev-oracle
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

andy-goryachev-oracle · 2025-07-03T14:41:01Z

modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFMediaPlayer.mm

-            unsigned int blockSize = locatorStream->GetCallbacks()->ReadNextBlock();
+            unsigned int blockSize = -1;
+            if (isRandomAccess) {
+                blockSize = locatorStream->GetCallbacks()->ReadBlock(pos, size);


would it make sense to declare a local variable for locatorStream->GetCallbacks() ?
or do we assume the compiler is smart enough to do that?

Not sure, but do not see a need from performance point view.

andy-goryachev-oracle · 2025-07-03T14:56:18Z

Would it be possible to come up with a system test?

modules/javafx.media/src/main/native/jfxmedia/platform/osx/OSXMediaPlayer.mm

modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFMediaPlayer.mm

sashamatveev · 2025-07-03T21:28:03Z

modules/javafx.media/src/main/native/jfxmedia/platform/osx/avf/AVFMediaPlayer.mm

-            unsigned int blockSize = locatorStream->GetCallbacks()->ReadNextBlock();
+            unsigned int blockSize = -1;
+            if (isRandomAccess) {
+                blockSize = locatorStream->GetCallbacks()->ReadBlock(pos, size);


Not sure, but do not see a need from performance point view.

sashamatveev · 2025-07-03T21:59:54Z

Looks good overall.

Undo changed in AVFMediaPlayer.mm. There is no need for it and this code will never execute.
Add NULL pointer check and deletion of callbacks if not NULL.
Change title for issue to something like MediaPlayer and AudioClip can crash when playing media files over "jar" and "jrt" protocols via OSXPlatform.

sashamatveev · 2025-07-08T02:55:37Z

8357714.0.patch

Patch which does not do seek with random access and it will read data starting from dataRequest.requestedOffset.
For size requestedLength is used. I do not see a need to use anything else. It will be limited to requested length or 1 Megabyte.
Added NULL checks and callbacks release.

Add null checks Fix errors in position and length calculations

johanvos · 2025-07-08T07:23:38Z

@sashamatveev Thanks a lot. That all makes sense, and it seems to work indeed with the corrected position/length calculations.

sashamatveev · 2025-07-08T20:55:05Z

modules/javafx.media/src/main/native/jfxmedia/platform/osx/OSXMediaPlayer.mm

        CJavaInputStreamCallbacks *callbacks = new (nothrow) CJavaInputStreamCallbacks();
-        if (callbacks == NULL) {
+        jobject jConnectionHolder = CLocator::CreateConnectionHolder(env, jLocator);
+        if (callbacks == NULL  || jConnectionHolder == NULL) {


Extra space after callbacks == NULL.

johanvos · 2025-07-10T07:46:11Z

Would it be possible to come up with a system test?

It would be great to have a system test, but we currently have no framework for testing media in the system tests. It would be good to create this, but I expect it to be lots of work (dealing with native code and different frameworks based on platform), so I think it's better in a separate issue

kevinrushforth · 2025-07-10T12:32:07Z

Would it be possible to come up with a system test?

It would be great to have a system test, but we currently have no framework for testing media in the system tests. It would be good to create this, but I expect it to be lots of work (dealing with native code and different frameworks based on platform), so I think it's better in a separate issue

Correct. We do not have such a framework, and it would be out of scope for this issue.

andy-goryachev-oracle · 2025-07-10T17:41:52Z

Got a reproducer for you: added AudioClip page to the Monkey Tester
https://github.com/andy-goryachev-oracle/MonkeyTest

Build a jar and run it. Select AudioClip page, then pressing "Play XX" button would play .wav or .mp3 file from the said jar.

edit: it works!

andy-goryachev-oracle · 2025-07-10T17:46:16Z

Unrelated to this PR:

Changing the rate property for mp3 has no effect (but does change the rate for a .wav). Changing the volume property does work. I wonder if this should be documented.
AudioClip properties specify no default values, we may need to address that.

I'll create a separate ticket later.

andy-goryachev-oracle · 2025-07-10T18:18:29Z

My apologies - forgot to build with -PCOMPILE_MEDIA=true.

The fixed code plays .mp3 from a jar without crashing.

andy-goryachev-oracle

the fix works with jdk23 or jdk24.
native code changes look ok to me

andy-goryachev-oracle · 2025-07-10T18:28:29Z

Should we test with other audio formats, or everything is piped through the same code path?

sashamatveev · 2025-07-10T19:51:36Z

Should we test with other audio formats, or everything is piped through the same code path?

I tested with all supported formats.

johanvos · 2025-07-11T17:28:29Z

/integrate

openjdk · 2025-07-11T17:29:13Z

Going to push as commit 203c049.
Since your change was applied there have been 4 commits pushed to the master branch:

e0f8e72: 8345348: CSS media feature queries
d6265e4: 8361710: Mark QPathTest as unstable on all platforms
6029e3e: 8359387: Bump minimum JDK version for JavaFX to JDK 23
... and 1 more: https://git.openjdk.org/jfx/compare/0270847b85ab6d4701abb201ec4b2aeee96129dd...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-07-11T17:29:25Z

@johanvos Pushed as commit 203c049.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Use ConnectionHolder instead of Locator for CJavaInputStreamCallbacks

b1459d0

In case of random access datasource, use readBlock instead of readNextBlock

openjdk bot added the rfr Ready for review label Jul 2, 2025

andy-goryachev-oracle reviewed Jul 3, 2025

View reviewed changes

sashamatveev reviewed Jul 3, 2025

View reviewed changes

Process reviewer comments

e99a850

Add null checks Fix errors in position and length calculations

sashamatveev reviewed Jul 8, 2025

View reviewed changes

Remove whitespace

15ce1ee

kevinrushforth requested review from andy-goryachev-oracle and sashamatveev July 10, 2025 12:32

andy-goryachev-oracle approved these changes Jul 10, 2025

View reviewed changes

sashamatveev approved these changes Jul 10, 2025

View reviewed changes

openjdk bot added the ready Ready to be integrated label Jul 10, 2025

openjdk bot added the integrated Pull request has been integrated label Jul 11, 2025

openjdk bot closed this Jul 11, 2025

openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jul 11, 2025

Conversation

johanvos commented Jul 2, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jul 2, 2025

Uh oh!

openjdk bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

johanvos commented Jul 3, 2025

Uh oh!

andy-goryachev-oracle commented Jul 3, 2025

Uh oh!

openjdk bot commented Jul 3, 2025

Uh oh!

andy-goryachev-oracle Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

sashamatveev Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

andy-goryachev-oracle commented Jul 3, 2025

Uh oh!

Uh oh!

Uh oh!

sashamatveev Jul 3, 2025

Choose a reason for hiding this comment

Uh oh!

sashamatveev commented Jul 3, 2025

Uh oh!

sashamatveev commented Jul 8, 2025

Uh oh!

johanvos commented Jul 8, 2025

Uh oh!

sashamatveev Jul 8, 2025

Choose a reason for hiding this comment

Uh oh!

johanvos Jul 10, 2025

Choose a reason for hiding this comment

Uh oh!

johanvos commented Jul 10, 2025

Uh oh!

kevinrushforth commented Jul 10, 2025

Uh oh!

andy-goryachev-oracle commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andy-goryachev-oracle commented Jul 10, 2025

Uh oh!

andy-goryachev-oracle commented Jul 10, 2025

Uh oh!

andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

Uh oh!

andy-goryachev-oracle commented Jul 10, 2025

Uh oh!

sashamatveev commented Jul 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johanvos commented Jul 11, 2025

Uh oh!

openjdk bot commented Jul 11, 2025

Uh oh!

openjdk bot commented Jul 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

johanvos commented Jul 2, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jul 2, 2025 •

edited

Loading

mlbridge bot commented Jul 2, 2025 •

edited

Loading

andy-goryachev-oracle commented Jul 10, 2025 •

edited

Loading

sashamatveev commented Jul 10, 2025 •

edited

Loading