Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242530: [macos] Some audio files miss spectrum data when another audio file plays first #184

Closed
wants to merge 1 commit into from

Conversation

@sashamatveev
Copy link
Member

@sashamatveev sashamatveev commented Apr 15, 2020

https://bugs.openjdk.java.net/browse/JDK-8242530

  • GstElementClass which is base class for all elements has same instance between all spectrum elements (not sure if it is same for all elements) and thus post_message was sending events to AVFoundation callback from GStreamer platform. This issue is reproducible if we load OSXPlatfrom first and then play media files using GStreamer. Fixed by introducing separate callback to send messages to AVFoundation.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242530: [macos] Some audio files miss spectrum data when another audio file plays first

Reviewers

  • Kevin Rushforth (kcr - Reviewer)
  • Ambarish Rapte (arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/184/head:pull/184
$ git checkout pull/184

…io file plays first
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 15, 2020

👋 Welcome back almatvee! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Apr 15, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 15, 2020

Webrevs

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 15, 2020

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Apr 15, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 15, 2020

@arapte Can you also review this?

@arapte
arapte approved these changes Apr 16, 2020
Copy link
Member

@arapte arapte left a comment

looks good to me...

@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2020

@sashamatveev This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242530: [macos] Some audio files miss spectrum data when another audio file plays first

Reviewed-by: kcr, arapte
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there has been 1 commit pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 7044cefbbd824027581382dd25aaa540aa0eae1a.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 16, 2020
@sashamatveev
Copy link
Member Author

@sashamatveev sashamatveev commented Apr 16, 2020

/integrate

@openjdk openjdk bot closed this Apr 16, 2020
@openjdk openjdk bot added integrated and removed ready labels Apr 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 16, 2020

@sashamatveev The following commits have been pushed to master since your change was applied:

  • 7044cef: 8241476: Linux build warnings issued on gcc 9

Your commit was automatically rebased without conflicts.

Pushed as commit e82046e.

@openjdk openjdk bot removed the rfr label Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants