8362095: HeaderButtonMetrics should not be used across toolkit boundary

[mstr2]

The record com.sun.glass.ui.HeaderButtonMetrics is used by Glass, but also in the FX layer (in Stage and HeaderBar). This is architectually unsound, as the FX layer should not directly reference the Glass implementation.

The solution here is to introduce another record that is used in the FX layer, and translate between the Glass/FX types in quantum toolkit.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8362095: HeaderButtonMetrics should not be used across toolkit boundary (Bug - P4)

Reviewers

• John Hendrikx (@hjohn - Reviewer)
• Kevin Rushforth (@kevinrushforth - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1846/head:pull/1846
$ git checkout pull/1846

Update a local copy of the PR:
$ git checkout pull/1846
$ git pull https://git.openjdk.org/jfx.git pull/1846/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1846

View PR using the GUI difftool:
$ git pr show -t 1846

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1846.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mstr2 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8362095: HeaderButtonMetrics should not be used across toolkit boundary

Reviewed-by: jhendrikx, kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• a574d92: 8359598: [TestBug] VirtualFlowTestUtils should not create a temporary Stage
• ff408b1: 8361713: JavaFX API docs overview is missing an intro section

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (d7346b0e)

[hjohn]

Looks fine.

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[kevinrushforth]

LGTM

[mstr2]

/integrate

[openjdk]

Going to push as commit 1a2a50b.
Since your change was applied there have been 2 commits pushed to the master branch:

• a574d92: 8359598: [TestBug] VirtualFlowTestUtils should not create a temporary Stage
• ff408b1: 8361713: JavaFX API docs overview is missing an intro section

Your commit was automatically rebased without conflicts.

[openjdk]

@mstr2 Pushed as commit 1a2a50b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.