Skip to content

Conversation

@arapte
Copy link
Member

@arapte arapte commented Jul 22, 2025

The JNI method NewObjectArray may return null, so a null check should be added as a precaution in methods that creates an array of Screens.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8363813: Missing null check in GlassScreen (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1851/head:pull/1851
$ git checkout pull/1851

Update a local copy of the PR:
$ git checkout pull/1851
$ git pull https://git.openjdk.org/jfx.git pull/1851/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1851

View PR using the GUI difftool:
$ git pr show -t 1851

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1851.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 22, 2025

👋 Welcome back arapte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 22, 2025

@arapte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8363813: Missing null check in GlassScreen

Reviewed-by: kcr, kizune, jvos, jdv

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Ready for review label Jul 22, 2025
@kevinrushforth kevinrushforth self-requested a review July 22, 2025 17:30
@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @johanvos

Johan: can you take a look at the/ios/ changes?

/reviewers 2

@openjdk
Copy link

openjdk bot commented Jul 22, 2025

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlbridge
Copy link

mlbridge bot commented Jul 22, 2025

Webrevs

@openjdk openjdk bot added the ready Ready to be integrated label Jul 23, 2025
@johanvos
Copy link
Collaborator

Johan: can you take a look at the/ios/ changes?

At first sight, those changes are not causing regression on ios. I'll do a deeper end-to-end test, but will already approve this since I don't want to stop this PR from being integrated.

@arapte
Copy link
Member Author

arapte commented Jul 23, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 23, 2025

Going to push as commit dbd43a3.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 7b59ebc: 8362873: Regression in BorderPane after JDK-8350149

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 23, 2025
@openjdk openjdk bot closed this Jul 23, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jul 23, 2025
@openjdk
Copy link

openjdk bot commented Jul 23, 2025

@arapte Pushed as commit dbd43a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@arapte
Copy link
Member Author

arapte commented Jul 23, 2025

/backport :jfx25

@openjdk
Copy link

openjdk bot commented Jul 23, 2025

@arapte the backport was successfully created on the branch backport-arapte-dbd43a37-jfx25 in my personal fork of openjdk/jfx. To create a pull request with this backport targeting openjdk/jfx:jfx25, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit dbd43a37 from the openjdk/jfx repository.

The commit being backported was authored by Ambarish Rapte on 23 Jul 2025 and was reviewed by Kevin Rushforth, Alexander Zuev, Johan Vos and Jayathirth D V.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx:

$ git fetch https://github.com/openjdk-bots/jfx.git backport-arapte-dbd43a37-jfx25:backport-arapte-dbd43a37-jfx25
$ git checkout backport-arapte-dbd43a37-jfx25
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jfx.git backport-arapte-dbd43a37-jfx25

⚠️ @arapte You are not yet a collaborator in my fork openjdk-bots/jfx. An invite will be sent out and you need to accept it before you can proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

5 participants