-
Notifications
You must be signed in to change notification settings - Fork 541
8363813: Missing null check in GlassScreen #1851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back arapte! A progress list of the required criteria for merging this PR into |
|
@arapte This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Reviewers: @kevinrushforth @johanvos Johan: can you take a look at the/ios/ changes? /reviewers 2 |
|
@kevinrushforth |
kevinrushforth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
At first sight, those changes are not causing regression on ios. I'll do a deeper end-to-end test, but will already approve this since I don't want to stop this PR from being integrated. |
|
/integrate |
|
/backport :jfx25 |
|
@arapte the backport was successfully created on the branch backport-arapte-dbd43a37-jfx25 in my personal fork of openjdk/jfx. To create a pull request with this backport targeting openjdk/jfx:jfx25, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jfx: |
The JNI method NewObjectArray may return null, so a null check should be added as a precaution in methods that creates an array of Screens.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1851/head:pull/1851$ git checkout pull/1851Update a local copy of the PR:
$ git checkout pull/1851$ git pull https://git.openjdk.org/jfx.git pull/1851/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1851View PR using the GUI difftool:
$ git pr show -t 1851Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1851.diff
Using Webrev
Link to Webrev Comment