Skip to content

Conversation

@mstr2
Copy link
Collaborator

@mstr2 mstr2 commented Jul 25, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8359601: Fix window button states of an extended stage (Bug - P4)
  • JDK-8359763: Close request handler is not called for an extended stage (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1855/head:pull/1855
$ git checkout pull/1855

Update a local copy of the PR:
$ git checkout pull/1855
$ git pull https://git.openjdk.org/jfx.git pull/1855/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1855

View PR using the GUI difftool:
$ git pr show -t 1855

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1855.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 25, 2025

👋 Welcome back mstrauss! A progress list of the required criteria for merging this PR into jfx25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 25, 2025

@mstr2 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8359601: Fix window button states of an extended stage
8359763: Close request handler is not called for an extended stage

Reviewed-by: kcr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jfx25 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jfx25 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport bc433da812461a1c2796cdb3123f814e4ce532d5 8359601: Fix window button states of an extended stage Jul 25, 2025
@openjdk
Copy link

openjdk bot commented Jul 25, 2025

This backport pull request has now been updated with issues from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Ready for review labels Jul 25, 2025
@mlbridge
Copy link

mlbridge bot commented Jul 25, 2025

Webrevs

@kevinrushforth kevinrushforth self-requested a review July 26, 2025 12:12
Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in the mainline PR, this is a good fix to backport to jfx25. The backport is clean.

@openjdk openjdk bot added the ready Ready to be integrated label Jul 26, 2025
@mstr2
Copy link
Collaborator Author

mstr2 commented Jul 26, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jul 26, 2025

Going to push as commit 5398b14.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 26, 2025
@openjdk openjdk bot closed this Jul 26, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Jul 26, 2025
@openjdk
Copy link

openjdk bot commented Jul 26, 2025

@mstr2 Pushed as commit 5398b14.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants