Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8243112: Skip failing test SVGTest.testSVGRenderingWithPattern #188

Closed
wants to merge 1 commit into from

Conversation

@arun-Joseph
Copy link
Collaborator

arun-Joseph commented Apr 18, 2020

SVGTest.testSVGRenderingWithPattern is failing frequently due to JDK-8243110. We should skip this test until it is fixed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8243112: Skip failing test SVGTest.testSVGRenderingWithPattern

Reviewers

  • Kevin Rushforth (kcr - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/188/head:pull/188
$ git checkout pull/188

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2020

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Apr 18, 2020
@openjdk
Copy link

openjdk bot commented Apr 18, 2020

@arun-Joseph This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8243112: Skip failing test SVGTest.testSVGRenderingWithPattern

Reviewed-by: kcr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate ec8608f39576035d41e8e532e9334b979b859543.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 18, 2020
@arun-Joseph
Copy link
Collaborator Author

arun-Joseph commented Apr 18, 2020

/integrate

@openjdk openjdk bot closed this Apr 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 18, 2020
@openjdk
Copy link

openjdk bot commented Apr 18, 2020

@arun-Joseph
Pushed as commit 1d88180.

@arun-Joseph arun-Joseph deleted the arun-Joseph:8243112 branch Apr 18, 2020
@mlbridge
Copy link

mlbridge bot commented Apr 18, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.