-
Notifications
You must be signed in to change notification settings - Fork 512
8242077: Add information about HTTP/2 and HttpClient usage in WebEngine #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back abhinayagarwal! A progress list of the required criteria for merging this PR into |
/reviewers 2 |
@kevinrushforth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I'd also like @guruhb to take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
@abhinayagarwal This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 8 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @guruhb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@abhinayagarwal |
/sponsor |
@kevinrushforth @abhinayagarwal The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit e30049f. |
Update WebEngine's Javadoc to add information on how it switches to HttpClient instead of URLConnection in JavaFX 14 when used with JDK 12 or later.
Identification of the correct client is important as both these clients may offer different ways to achieve a task. One such task can be bypassing insecure HTTPS connection.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jfx pull/189/head:pull/189
$ git checkout pull/189