Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242077: Add information about HTTP/2 and HttpClient usage in WebEngine #189

Closed
wants to merge 2 commits into from

Conversation

@abhinayagarwal
Copy link
Contributor

@abhinayagarwal abhinayagarwal commented Apr 19, 2020

Update WebEngine's Javadoc to add information on how it switches to HttpClient instead of URLConnection in JavaFX 14 when used with JDK 12 or later.

Identification of the correct client is important as both these clients may offer different ways to achieve a task. One such task can be bypassing insecure HTTPS connection.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242077: inconsistent behavior for expired certificates (combination JDK/JavaFX version)

Reviewers

  • Kevin Rushforth (kcr - Reviewer)
  • Guru Hb (ghb - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/189/head:pull/189
$ git checkout pull/189

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 19, 2020

👋 Welcome back abhinayagarwal! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Apr 19, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 19, 2020

Webrevs

@kevinrushforth kevinrushforth self-requested a review Apr 21, 2020
@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 21, 2020

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Apr 21, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

This looks good to me. I'd also like @guruhb to take a look.

@guruhb
guruhb approved these changes Apr 28, 2020
Copy link
Collaborator

@guruhb guruhb left a comment

looks good to me

@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2020

@abhinayagarwal This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242077: Add information about HTTP/2 and HttpClient usage in WebEngine

Reviewed-by: kcr, ghb
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 8 commits pushed to the master branch:

  • e0ffca3: 8242505: Some WebKit tests might fail because Microsoft libraries are not loaded
  • ceb3fce: 8087555: [ChoiceBox] uncontained value not shown
  • 818ac00: 8175358: Memory leak when moving MenuButton into another Scene
  • 91d4c8b: 8241737: TabPaneSkin memory leak on replacing selectionModel
  • 48476eb: 8241582: Infinite animation does not start from the end when started with a negative rate
  • dedf7cb: 8242490: Upgrade to gcc 9.2 on Linux
  • 5e9fb82: 8242577: Cell selection fails on iOS most of the times
  • 69e4266: 8242489: ChoiceBox: initially toggle not sync'ed to selection

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e0ffca32c5c6d98be9e43a4c2b7c1fb7f5216e85.

As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @guruhb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Apr 28, 2020
@abhinayagarwal
Copy link
Contributor Author

@abhinayagarwal abhinayagarwal commented Apr 28, 2020

/integrate

@openjdk openjdk bot added the sponsor label Apr 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2020

@abhinayagarwal
Your change (at version 36b7aab) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 28, 2020

/sponsor

@openjdk openjdk bot closed this Apr 28, 2020
@openjdk openjdk bot added integrated and removed sponsor ready labels Apr 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2020

@kevinrushforth @abhinayagarwal The following commits have been pushed to master since your change was applied:

  • e0ffca3: 8242505: Some WebKit tests might fail because Microsoft libraries are not loaded
  • ceb3fce: 8087555: [ChoiceBox] uncontained value not shown
  • 818ac00: 8175358: Memory leak when moving MenuButton into another Scene
  • 91d4c8b: 8241737: TabPaneSkin memory leak on replacing selectionModel
  • 48476eb: 8241582: Infinite animation does not start from the end when started with a negative rate
  • dedf7cb: 8242490: Upgrade to gcc 9.2 on Linux
  • 5e9fb82: 8242577: Cell selection fails on iOS most of the times
  • 69e4266: 8242489: ChoiceBox: initially toggle not sync'ed to selection

Your commit was automatically rebased without conflicts.

Pushed as commit e30049f.

@openjdk openjdk bot removed the rfr label Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants