8242861: Update ImagePattern to apply SVG pattern transforms

[arun-joseph]

fillPath() and fillRect() functions in GraphicsContextJava.cpp use Image::drawPattern() for applying patterns as fill. But drawPattern() doesn't use patternTransform argument as ImagePattern doesn't have the same attribute. So, the final image won't be transformed.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8242861: Update ImagePattern to apply SVG pattern transforms

Reviewers

• Kevin Rushforth (@kevinrushforth - Reviewer)
• Ambarish Rapte (@arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/190/head:pull/190
$ git checkout pull/190

[bridgekeeper]

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 06: Full - Incremental (abb4787)
• 05: Full - Incremental (4241c50)
• 04: Full - Incremental (d808d27)
• 03: Full - Incremental (9b841f4)
• 02: Full - Incremental (2e2b5cd)
• 01: Full - Incremental (76e4745)
• 00: Full (c1066e9)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[kevinrushforth]

Since this is in a common method used by all shapes, and not just WebView, we will need to ensure no regressions.

[arun-joseph]

All ImagePattern objects, other than the one from WebView, uses the second constructor which assigns an identity transform as the pattern transform. So, existing calls to PaintHelper concatenates the shader transform with an identity matrix and thus, shouldn't cause any regressions. Only calls from WebView's drawPattern() method in WCGraphicsPrismContext uses the patternTransform attribute.

[arun-joseph]

The changes in drawPattern() forces the function to handle the operations for drawPattern (for images) and fillPattern (for shapes) together. If required, a new opcode SET_FILL_PATTERN can be introduced for handling patterns in shapes and part of the implementation can be seen from my previous commits to this PR.

[kevinrushforth]

This works for the HW accelerated pipeline, but you need to also modify the SW pipeline and J2D pipeline (used for printing). See SWPaint::computeImagePatternTransform and the ImagePattern case in J2DPrismGraphics::toJ2DPaint. In the J2D pipeline case, you will have more work to do, since it doesn't use a pattern transform that I can see.

[kevinrushforth]

This looks good to me with one suggestion and one request for a clarifying comment.

[arapte]

Added a small query comment.
Rest looks good to me, change seems specific to ImagePattern transformation. This transformation is set only when specified from webkit and is identity otherwise.

[openjdk]

@arun-joseph This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8242861: Update ImagePattern to apply SVG pattern transforms

Reviewed-by: kcr, arapte

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 173 new commits pushed to the master branch:

• ade3227: 8254569: Remove hard dependency on Dispman in Monocle fb rendering
• 08d8a98: 8237491: [Linux] Undecorated stage cannot be maximized
• 92804f3: 8255723: Gtk glass backend should run with Gtk+ 3.8 (minimum)
• eece20b: 8255714: Switch FX build to use JDK 15.0.1 as boot JDK
• c31ed6b: 8255415: Nested calls to snap methods in Region give different results
• cb545cc: 8253634: TreeCell/Skin: misbehavior on switching skin
• 51c09e5: 8254691: Enable GitHub actions for jfx repo
• 1a11334: 8244297: Provide utility for testing for memory leaks
• 0376e60: 8255487: Mark SandboxAppTest unstable on Windows
• 7da928b: 8255497: [TestBug] Controls unit tests - clean up unnecessary prints on STANDARD_OUT
• ... and 163 more: https://git.openjdk.java.net/jfx/compare/1d8818060d34b31c006375b07996c8665e891eac...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[arun-joseph]

/integrate

[openjdk]

@arun-joseph Since your change was applied there have been 173 commits pushed to the master branch:

• ade3227: 8254569: Remove hard dependency on Dispman in Monocle fb rendering
• 08d8a98: 8237491: [Linux] Undecorated stage cannot be maximized
• 92804f3: 8255723: Gtk glass backend should run with Gtk+ 3.8 (minimum)
• eece20b: 8255714: Switch FX build to use JDK 15.0.1 as boot JDK
• c31ed6b: 8255415: Nested calls to snap methods in Region give different results
• cb545cc: 8253634: TreeCell/Skin: misbehavior on switching skin
• 51c09e5: 8254691: Enable GitHub actions for jfx repo
• 1a11334: 8244297: Provide utility for testing for memory leaks
• 0376e60: 8255487: Mark SandboxAppTest unstable on Windows
• 7da928b: 8255497: [TestBug] Controls unit tests - clean up unnecessary prints on STANDARD_OUT
• ... and 163 more: https://git.openjdk.java.net/jfx/compare/1d8818060d34b31c006375b07996c8665e891eac...master

Your commit was automatically rebased without conflicts.

Pushed as commit dd22cd2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.