Skip to content

8367602: Regression: TabPane with wrapped label calculates wrong initial size#1908

Closed
hjohn wants to merge 1 commit intoopenjdk:jfx25from
openjdk-bots:backport-hjohn-7e692bd0-jfx25
Closed

8367602: Regression: TabPane with wrapped label calculates wrong initial size#1908
hjohn wants to merge 1 commit intoopenjdk:jfx25from
openjdk-bots:backport-hjohn-7e692bd0-jfx25

Conversation

@hjohn
Copy link
Collaborator

@hjohn hjohn commented Sep 17, 2025


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8367602: Regression: TabPane with wrapped label calculates wrong initial size (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1908/head:pull/1908
$ git checkout pull/1908

Update a local copy of the PR:
$ git checkout pull/1908
$ git pull https://git.openjdk.org/jfx.git pull/1908/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1908

View PR using the GUI difftool:
$ git pr show -t 1908

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1908.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2025

👋 Welcome back jhendrikx! A progress list of the required criteria for merging this PR into jfx25 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 17, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 7e692bd0a577b13a40414adc3ba2a18e02855a40 8367602: Regression: TabPane with wrapped label calculates wrong initial size Sep 17, 2025
@openjdk
Copy link

openjdk bot commented Sep 17, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Ready for review labels Sep 17, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 17, 2025

Webrevs

@kevinrushforth
Copy link
Member

The jfx25 branch was the stabilization branch for JavaFX 25, which released yesterday, and is now closed.

Backport this fix to the jfx25u repo instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Ready for review

Development

Successfully merging this pull request may close these issues.

2 participants