8368219: Skip MenuDoubleShortcutTest on macOS & Linux#1916
8368219: Skip MenuDoubleShortcutTest on macOS & Linux#1916jayathirthrao wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back jdv! A progress list of the required criteria for merging this PR into |
|
@jayathirthrao This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Since this is a simple addition to skip failing tests, no need to wait 24 hours. |
|
/integrate |
|
Going to push as commit f2cc78b. |
|
@jayathirthrao Pushed as commit f2cc78b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
MenuDoubleShortcutTest > nonMacMenuBarComesBeforeScene()/macSceneComesBeforeMenuBar() was failing intermittently and it was made more robust under JDK-8364405 and it was verified with multiple runs and it was passing.
But looks like we still see this test failing in our CI. We need to skip this test and test fix will be worked upon under JDK-8368074
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1916/head:pull/1916$ git checkout pull/1916Update a local copy of the PR:
$ git checkout pull/1916$ git pull https://git.openjdk.org/jfx.git pull/1916/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1916View PR using the GUI difftool:
$ git pr show -t 1916Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1916.diff
Using Webrev
Link to Webrev Comment