8238080: FXMLLoader: if script engines implement javax.script.Compilable compile scripts #192
…mpilable compile scripts
…ce error can be resolved (why would jcheck not do it automagically as well as expanding tabs?)
…scripts; PI data can be truei (default) or false
============================ test units for: compile PI+fallback
I think the approach proposed in this PR is the best solution for this enhancement. Go ahead and remove the
The interface and behavior change will need to be specified in the API docs. This can be done by modifying the Introduction to FXML document. I recommend documenting the new behavior and
As discussed on the mailing list, this will need a CSR, which should include the changes to the docs.
@kevinrushforth has indicated that a compatibility and specification (CSR) request is needed for this pull request.
Kevin, thank you for your feedback and sponsorship!
Hope that I have applied the changes to all affected files appropriately. (It is interesting for me that despite trying to adhere to the OpenJDK formatting, sometimes my own - decadelong trained :) - formattings slip thru without noticing it.)
@ronyfla This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 15 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge
As you are not a known OpenJDK Author, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@kevinrushforth, @aghaisas) but any other Committer may sponsor as well.
➡️ To flag this PR as ready for integration with the above commit message, type
Kevin looked into it already yesterday. There was some problem at github at the time I submitted the /integrate comment, which merely needs to be reissued by me. Having been on the road I was not able to do it yesterday, will be first thing after arriving at the office today.
Rony G. Flatscher (mobil/e)
Your commit was automatically rebased without conflicts.
Pushed as commit 45c9854.