Skip to content

Conversation

@Ziad-Mid
Copy link
Contributor

@Ziad-Mid Ziad-Mid commented Sep 29, 2025

Changed Group name to PopupWindow in cssref.html


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368511: Incorrect "Group" name after click on link in JavaFX CSS Reference Guide (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1923/head:pull/1923
$ git checkout pull/1923

Update a local copy of the PR:
$ git checkout pull/1923
$ git pull https://git.openjdk.org/jfx.git pull/1923/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1923

View PR using the GUI difftool:
$ git pr show -t 1923

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1923.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2025

👋 Welcome back zelmidaoui! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 29, 2025

@Ziad-Mid This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8368511: Incorrect "Group" name after click on link in JavaFX CSS Reference Guide

Reviewed-by: angorya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@andy-goryachev-oracle) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@Ziad-Mid Ziad-Mid marked this pull request as ready for review September 29, 2025 17:11
@openjdk openjdk bot added the rfr Ready for review label Sep 29, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2025

Webrevs

Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took 8 years for this issue to be discovered...

@openjdk openjdk bot added the ready Ready to be integrated label Sep 29, 2025
@Ziad-Mid
Copy link
Contributor Author

Ziad-Mid commented Oct 1, 2025

Thanks for the review.

@Ziad-Mid
Copy link
Contributor Author

Ziad-Mid commented Oct 1, 2025

/integrate

@openjdk openjdk bot added the sponsor Ready to sponsor label Oct 1, 2025
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@Ziad-Mid
Your change (at version 8785b55) is now ready to be sponsored by a Committer.

@kevinrushforth
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 1, 2025

Going to push as commit 76aba9a.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 1, 2025
@openjdk openjdk bot closed this Oct 1, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review sponsor Ready to sponsor labels Oct 1, 2025
@openjdk
Copy link

openjdk bot commented Oct 1, 2025

@kevinrushforth @Ziad-Mid Pushed as commit 76aba9a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Ziad-Mid Ziad-Mid deleted the 8368511.cssgroupname branch November 27, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants