Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242505: Some WebKit tests might fail because Microsoft libraries are not loaded #194

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 22, 2020

This PR will allow javafx.web unit tests to run to completion and pass on Windows with Visual Studio 2019.

Two of the WebKit tests load the native WebKit library without initializing the JavaFX runtime. This will lead to test failures and will hang the test run if those tests are run before the other tests, and if the system doesn't have all the needed runtime libraries.

The simple fix is to call the Toolkit method to load those libraries. This is only needed for unit tests that don't already initialize the JavaFX runtime (e.g., by calling Platform::startup or Application::launch) and call internal methods that execute native code as part of the test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242505: Some WebKit tests might fail because Microsoft libraries are not loaded

Reviewers

  • Guru Hb (ghb - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/194/head:pull/194
$ git checkout pull/194

@kevinrushforth kevinrushforth self-assigned this Apr 22, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 22, 2020

@guruhb can you review this?

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 22, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Apr 22, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 22, 2020

Webrevs

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 22, 2020

Worth noting is that it is possible for this to fail even with the VS2017 compiler on some systems, but I haven't seen it myself (I've seen similar enough failures to know that it's possible).

@guruhb
guruhb approved these changes Apr 28, 2020
Copy link
Collaborator

@guruhb guruhb left a comment

Looks good to me

@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242505: Some WebKit tests might fail because Microsoft libraries are not loaded

Reviewed-by: ghb
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 10 commits pushed to the master branch:

  • ceb3fce: 8087555: [ChoiceBox] uncontained value not shown
  • 818ac00: 8175358: Memory leak when moving MenuButton into another Scene
  • 91d4c8b: 8241737: TabPaneSkin memory leak on replacing selectionModel
  • 48476eb: 8241582: Infinite animation does not start from the end when started with a negative rate
  • dedf7cb: 8242490: Upgrade to gcc 9.2 on Linux
  • 5e9fb82: 8242577: Cell selection fails on iOS most of the times
  • 69e4266: 8242489: ChoiceBox: initially toggle not sync'ed to selection
  • 1d88180: 8243112: Skip failing test SVGTest.testSVGRenderingWithPattern
  • ec8608f: 8223298: SVG patterns are drawn wrong
  • e82046e: 8242530: [macos] Some audio files miss spectrum data when another audio file plays first

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate ceb3fcebe5ac147c0b694668a96801af19d0b007.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 28, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented Apr 28, 2020

/integrate

@openjdk openjdk bot closed this Apr 28, 2020
@openjdk openjdk bot added integrated and removed ready labels Apr 28, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2020

@kevinrushforth The following commits have been pushed to master since your change was applied:

  • ceb3fce: 8087555: [ChoiceBox] uncontained value not shown
  • 818ac00: 8175358: Memory leak when moving MenuButton into another Scene
  • 91d4c8b: 8241737: TabPaneSkin memory leak on replacing selectionModel
  • 48476eb: 8241582: Infinite animation does not start from the end when started with a negative rate
  • dedf7cb: 8242490: Upgrade to gcc 9.2 on Linux
  • 5e9fb82: 8242577: Cell selection fails on iOS most of the times
  • 69e4266: 8242489: ChoiceBox: initially toggle not sync'ed to selection
  • 1d88180: 8243112: Skip failing test SVGTest.testSVGRenderingWithPattern
  • ec8608f: 8223298: SVG patterns are drawn wrong
  • e82046e: 8242530: [macos] Some audio files miss spectrum data when another audio file plays first

Your commit was automatically rebased without conflicts.

Pushed as commit e0ffca3.

@openjdk openjdk bot removed the rfr label Apr 28, 2020
@kevinrushforth kevinrushforth deleted the kevinrushforth:8242505-fix-tests branch May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants