8370632: Additional libxslt 1.1.43 fixes#1949
8370632: Additional libxslt 1.1.43 fixes#1949HimaBinduMeda wants to merge 3 commits intoopenjdk:masterfrom
Conversation
|
👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into |
|
@HimaBinduMeda This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
|
Reviewers: @kevinrushforth @jaybhaskar /reviewers 2 |
|
@kevinrushforth |
kevinrushforth
left a comment
There was a problem hiding this comment.
LGTM. The indentation looks a little off in a couple places, so you might want to check it. I'll reapprove if you make any changes.
|
/integrate |
|
Going to push as commit 478e1ad. |
|
@HimaBinduMeda Pushed as commit 478e1ad. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Additional fixes for libxslt 1.1.43. Verified build and sanity.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1949/head:pull/1949$ git checkout pull/1949Update a local copy of the PR:
$ git checkout pull/1949$ git pull https://git.openjdk.org/jfx.git pull/1949/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1949View PR using the GUI difftool:
$ git pr show -t 1949Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1949.diff
Using Webrev
Link to Webrev Comment