Skip to content

8370632: Additional libxslt 1.1.43 fixes#1949

Closed
HimaBinduMeda wants to merge 3 commits intoopenjdk:masterfrom
HimaBinduMeda:xslt-additionalfix
Closed

8370632: Additional libxslt 1.1.43 fixes#1949
HimaBinduMeda wants to merge 3 commits intoopenjdk:masterfrom
HimaBinduMeda:xslt-additionalfix

Conversation

@HimaBinduMeda
Copy link
Contributor

@HimaBinduMeda HimaBinduMeda commented Oct 27, 2025

Additional fixes for libxslt 1.1.43. Verified build and sanity.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

  • JDK-8370632: Additional libxslt 1.1.43 fixes (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1949/head:pull/1949
$ git checkout pull/1949

Update a local copy of the PR:
$ git checkout pull/1949
$ git pull https://git.openjdk.org/jfx.git pull/1949/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1949

View PR using the GUI difftool:
$ git pr show -t 1949

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1949.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2025

👋 Welcome back hmeda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

@HimaBinduMeda This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8370632: Additional libxslt 1.1.43 fixes

Reviewed-by: kcr, jbhaskar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Ready for review label Oct 27, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2025

Webrevs

@kevinrushforth
Copy link
Member

Reviewers: @kevinrushforth @jaybhaskar

/reviewers 2

@openjdk
Copy link

openjdk bot commented Oct 27, 2025

@kevinrushforth
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

Copy link
Member

@kevinrushforth kevinrushforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The indentation looks a little off in a couple places, so you might want to check it. I'll reapprove if you make any changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation is off.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indentation

@kevinrushforth kevinrushforth self-requested a review October 27, 2025 18:16
Copy link
Member

@jaybhaskar jaybhaskar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@openjdk openjdk bot added the ready Ready to be integrated label Oct 28, 2025
@HimaBinduMeda
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2025

Going to push as commit 478e1ad.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2025
@openjdk openjdk bot closed this Oct 28, 2025
@openjdk openjdk bot removed ready Ready to be integrated rfr Ready for review labels Oct 28, 2025
@openjdk
Copy link

openjdk bot commented Oct 28, 2025

@HimaBinduMeda Pushed as commit 478e1ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants

Comments