Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8171898: [WebView] ScrollBarWidget thickness calculation is not correct #197

Closed
wants to merge 1 commit into from

Conversation

@arun-Joseph
Copy link
Member

@arun-Joseph arun-Joseph commented Apr 27, 2020

ScrollbarThemeJava delegates scrollbar thickness calculation to ScrollBarWidget::initializeThickness() [ScrollBarWidget.java] method. Since "ScrollbarThemeJava::scrollbarThickness" is not associated with any "ScrollBarWidget" instance, some workaround was made using special "ScrollBarWidget" instance named testRef.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8171898: [WebView] ScrollBarWidget thickness calculation is not correct

Download

$ git fetch https://git.openjdk.java.net/jfx pull/197/head:pull/197
$ git checkout pull/197

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 27, 2020

👋 Welcome back ajoseph! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Apr 27, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 27, 2020

Webrevs

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 27, 2020

/reviewers 2

@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 28, 2020

While this might be the right fix, I don't think the evaluation is right. In particular, this doesn't look related to JDK-8157900. That refactoring fix was behavior neutral in terms of the object graph -- it uses an accessor pattern rather than the removed public impl_ methods for encapsulation, but intentionally didn't change anything related to which instance of which objects are used. That fix was not backported to 8u and yet this bug is listed as affecting 8u.

So, what I'd like to see in the evaluation is a description of the root cause, and a brief explanation of the fix.

Can you also provide a test case that fails without the fix and passes with the fix? I don't see one in JBS that you can leverage, so you may need to create one.

@arun-Joseph
Copy link
Member Author

@arun-Joseph arun-Joseph commented Apr 29, 2020

This PR aims at modifying initializeThickness() to not use testSBRef and so, doesn't change the behavior of ScrollBarWidget. As it's not a bug, test case can't be created.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Apr 29, 2020

If it is not a bug, then why should we fix it?

@arun-Joseph arun-Joseph closed this May 5, 2020
@arun-Joseph arun-Joseph deleted the arun-Joseph:8171898 branch May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants