Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8243115: Spurious invalidations due to bug in IntegerBinding and other classes #198

Open
wants to merge 1 commit into
base: master
from
Open
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file
Failed to load files.

Always

Just for now

@@ -67,6 +67,13 @@ public BooleanBinding() {

private boolean value;
private boolean valid = false;

/**
* Invalidation listener used for observing dependencies. This
* is never cleared once created as there is no way to determine
* when all dependencies that were previously bound were removed
* in one or more calls to {@link #unbind(Observable...)}.
*/
private BindingHelperObserver observer;
private ExpressionHelper<Boolean> helper = null;

@@ -119,7 +126,6 @@ protected final void unbind(Observable... dependencies) {
for (final Observable dep : dependencies) {
dep.removeListener(observer);
}
observer = null;
}
}

@@ -113,6 +113,13 @@

private double value;
private boolean valid;

/**
* Invalidation listener used for observing dependencies. This
* is never cleared once created as there is no way to determine
* when all dependencies that were previously bound were removed
* in one or more calls to {@link #unbind(Observable...)}.
*/
private BindingHelperObserver observer;
private ExpressionHelper<Number> helper = null;

@@ -165,7 +172,6 @@ protected final void unbind(Observable... dependencies) {
for (final Observable dep : dependencies) {
dep.removeListener(observer);
}
observer = null;
}
}

@@ -63,6 +63,13 @@

private float value;
private boolean valid;

/**
* Invalidation listener used for observing dependencies. This
* is never cleared once created as there is no way to determine
* when all dependencies that were previously bound were removed
* in one or more calls to {@link #unbind(Observable...)}.
*/
private BindingHelperObserver observer;
private ExpressionHelper<Number> helper = null;

@@ -115,7 +122,6 @@ protected final void unbind(Observable... dependencies) {
for (final Observable dep : dependencies) {
dep.removeListener(observer);
}
observer = null;
}
}

@@ -63,6 +63,13 @@

private int value;
private boolean valid = false;

/**
* Invalidation listener used for observing dependencies. This
* is never cleared once created as there is no way to determine
* when all dependencies that were previously bound were removed
* in one or more calls to {@link #unbind(Observable...)}.
*/
private BindingHelperObserver observer;
private ExpressionHelper<Number> helper = null;

@@ -115,7 +122,6 @@ protected final void unbind(Observable... dependencies) {
for (final Observable dep : dependencies) {
dep.removeListener(observer);
}
observer = null;
}
}

@@ -75,6 +75,13 @@ public void onChanged(Change<? extends E> change) {

private ObservableList<E> value;
private boolean valid = false;

/**
* Invalidation listener used for observing dependencies. This
* is never cleared once created as there is no way to determine
* when all dependencies that were previously bound were removed
* in one or more calls to {@link #unbind(Observable...)}.
*/
private BindingHelperObserver observer;
private ListExpressionHelper<E> helper = null;

@@ -203,7 +210,6 @@ protected final void unbind(Observable... dependencies) {
dep.removeListener(observer);
}
}
observer = null;
}
}

@@ -63,6 +63,13 @@

private long value;
private boolean valid = false;

/**
* Invalidation listener used for observing dependencies. This
* is never cleared once created as there is no way to determine
* when all dependencies that were previously bound were removed
* in one or more calls to {@link #unbind(Observable...)}.
*/
private BindingHelperObserver observer;
private ExpressionHelper<Number> helper = null;

@@ -115,7 +122,6 @@ protected final void unbind(Observable... dependencies) {
for (final Observable dep : dependencies) {
dep.removeListener(observer);
}
observer = null;
}
}

@@ -63,6 +63,13 @@

private T value;
private boolean valid = false;

/**
* Invalidation listener used for observing dependencies. This
* is never cleared once created as there is no way to determine
* when all dependencies that were previously bound were removed
* in one or more calls to {@link #unbind(Observable...)}.
*/
private BindingHelperObserver observer;
private ExpressionHelper<T> helper = null;

@@ -115,7 +122,6 @@ protected final void unbind(Observable... dependencies) {
for (final Observable dep : dependencies) {
dep.removeListener(observer);
}
observer = null;
}
}

@@ -62,6 +62,13 @@

private String value;
private boolean valid = false;

/**
* Invalidation listener used for observing dependencies. This
* is never cleared once created as there is no way to determine
* when all dependencies that were previously bound were removed
* in one or more calls to {@link #unbind(Observable...)}.
*/
private BindingHelperObserver observer;
private ExpressionHelper<String> helper = null;

@@ -114,7 +121,6 @@ protected final void unbind(Observable... dependencies) {
for (final Observable dep : dependencies) {
dep.removeListener(observer);
}
observer = null;
}
}

ProTip! Use n and p to navigate between commits in a pull request.