8241999: ChoiceBox: incorrect toggle selected for uncontained #200
The issue is that the toggles is not reliably unselected if an uncontained value is set.
The root is ChoiceBoxSelectionModel which doesn't update the index on selecting an uncontained item, in particular it fails to keep the invariant:
The fix here is to override select(item) to guarantee the assert.
Added/removed ignore from tests that failed before and pass after the fix. All other tests are passing before and after.
@kleopatra This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 7 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge
As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@aghaisas) but any other Committer may sponsor as well.
Your commit was automatically rebased without conflicts.
Pushed as commit 99f7747.