8244421: Wrong scrollbar position on touch enabled devices

[jperedadnr]

VirtualFlow makes use of VirtualScrollBar controls, that are laid out next to the clipped container region, by default.

However, when touch is supported, these scrollBars are floating controls laid out over the container. Therefore, in this case, when the viewport dimensions are updated, the presence of the scrollBars shouldn't be taken into account.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8244421: Wrong scrollbar position on touch enabled devices

Reviewers

• Johan Vos (jvos - Reviewer)
• Ajit Ghaisas (aghaisas - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/208/head:pull/208
$ git checkout pull/208

[bridgekeeper]

👋 Welcome back jpereda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

[mlbridge]

Webrevs

• 00: Full (2e1cb40)

[kevinrushforth]

/reviewers 2

[openjdk]

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

[kevinrushforth]

@aghaisas can you also take a look?

[kevinrushforth]

I've asked Ajit to review it (and I presume Johan will review as well?)

It looks like a safe enough fix. Have you tested it on multiple platforms?

[jperedadnr]

Yes, I've tested on Mac OS and Linux (with or without -Dcom.sun.javafx.touch=true), and also on Android and iOS.

[johanvos]

I confirm this fixes JBS-8244421

[openjdk]

@jperedadnr This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244421: Wrong scrollbar position on touch enabled devices

Reviewed-by: jvos, aghaisas

• If you would like to add a summary, use the /summary command.
• To credit additional contributors, use the /contributor command.
• To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

• 0385563: 8243255: Font size is large in JavaFX app with enabled Monocle on Raspberry Pi
• 2e90076: 8242507: Add support for Visual Studio 2019
• 39d9c3b: 8244110: NPE in MenuButtonSkinBase change listener

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 038556390ef30c912139fcb828ee4a41d8c5abc8.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@johanvos, @aghaisas) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jperedadnr]

/integrate

[openjdk]

@jperedadnr
Your change (at version 2e1cb40) is now ready to be sponsored by a Committer.

[aghaisas]

/sponsor

[openjdk]

@aghaisas @jperedadnr The following commits have been pushed to master since your change was applied:

• 0385563: 8243255: Font size is large in JavaFX app with enabled Monocle on Raspberry Pi
• 2e90076: 8242507: Add support for Visual Studio 2019
• 39d9c3b: 8244110: NPE in MenuButtonSkinBase change listener

Your commit was automatically rebased without conflicts.

Pushed as commit 236e2d6.