Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244487: One Windows 10 SDK file missing from FX build #211

Closed

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 6, 2020

While auditing the list of redistributed Microsoft files in the JDK versus FX, I discovered one file that the JDK ships that FX does not:

api-ms-win-core-console-l1-2-0.dll

I checked the Redist directory in the Windows 10 SDK and this is the only one we are missing.

Root cause: the current version of the Windows 10 SDK has 41 redistributable api-ms-win-* files. There were 40 when we first upgraded to VS 2017 and Windows 10 SDK three years ago. We didn't reexamine the list when upgrading to a later minor version of VS 2017 and the Windows 10 SDK.

We haven't yet seen any problems as a result, but since we are getting ready to upgrade to VS 2019 see JDK-8242508 -- we should correct this so it doesn't cause problems in the future.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8244487: One Windows 10 SDK file missing from FX build

Reviewers

  • Johan Vos (jvos - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/211/head:pull/211
$ git checkout pull/211

@kevinrushforth kevinrushforth self-assigned this May 6, 2020
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 6, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 6, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 6, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented May 7, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8244487: One Windows 10 SDK file missing from FX build

Reviewed-by: jvos
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • 4ec163d: 8242001: ChoiceBox: must update value on setting SelectionModel, part2
  • 236e2d6: 8244421: Wrong scrollbar position on touch enabled devices
  • 0385563: 8243255: Font size is large in JavaFX app with enabled Monocle on Raspberry Pi

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 4ec163df90c88cc01b70d58831ad2abdb86c196d.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 7, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented May 11, 2020

/integrate

@openjdk openjdk bot closed this May 11, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 11, 2020

@kevinrushforth The following commits have been pushed to master since your change was applied:

  • 4ec163d: 8242001: ChoiceBox: must update value on setting SelectionModel, part2
  • 236e2d6: 8244421: Wrong scrollbar position on touch enabled devices
  • 0385563: 8243255: Font size is large in JavaFX app with enabled Monocle on Raspberry Pi

Your commit was automatically rebased without conflicts.

Pushed as commit 0f87d20.

@kevinrushforth kevinrushforth deleted the kevinrushforth:8244487-win10-sdk-file branch May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants