Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242508: Upgrade to Visual Studio 2019 version 16.5.3 #212

Closed
wants to merge 1 commit into from

Conversation

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented May 6, 2020

This is a toolchain upgrade on Windows from the current Visual Studio 2017 (version 15.9.16) to Visual Studio 2019 (version 16.5.3). This will match a recent upgrade done for JDK 15 -- see JDK-8244214.

I have run a full build and test using this new compiler.

NOTE: although this isn't strictly dependent on JDK-8244487, which is out for review as PR #211 , I plan to wait until that one is approved. I will then integrate PR #211 followed by this PR.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242508: Upgrade to Visual Studio 2019 version 16.5.3

Reviewers

  • Johan Vos (jvos - Reviewer)
  • Ambarish Rapte (arapte - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jfx pull/212/head:pull/212
$ git checkout pull/212

@kevinrushforth kevinrushforth requested a review from johanvos May 6, 2020
@kevinrushforth kevinrushforth self-assigned this May 6, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented May 6, 2020

/reviewers 2

@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented May 6, 2020

@arapte can you also review this?

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 6, 2020

👋 Welcome back kcr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label May 6, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 6, 2020

@kevinrushforth
The number of required reviews for this PR is now set to 2 (with at least 1 of role reviewers).

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 6, 2020

Webrevs

Copy link
Collaborator

@johanvos johanvos left a comment

Confirmed to work on our build system.

@arapte
arapte approved these changes May 11, 2020
Copy link
Member

@arapte arapte left a comment

lgtm, verified a local build on Windows10.

@openjdk
Copy link

@openjdk openjdk bot commented May 11, 2020

@kevinrushforth This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

8242508: Upgrade to Visual Studio 2019 version 16.5.3

Reviewed-by: jvos, arapte
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 5 commits pushed to the master branch:

  • b0d66d0: 8242508: Upgrade to Visual Studio 2019 version 16.5.3
  • 0f87d20: 8244487: One Windows 10 SDK file missing from FX build
  • 4ec163d: 8242001: ChoiceBox: must update value on setting SelectionModel, part2
  • 236e2d6: 8244421: Wrong scrollbar position on touch enabled devices
  • 0385563: 8243255: Font size is large in JavaFX app with enabled Monocle on Raspberry Pi

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate b0d66d0ded97d1a6514729dac73bc127868326da.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label May 11, 2020
@kevinrushforth
Copy link
Member Author

@kevinrushforth kevinrushforth commented May 11, 2020

/integrate

@openjdk openjdk bot closed this May 11, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels May 11, 2020
@openjdk
Copy link

@openjdk openjdk bot commented May 11, 2020

@kevinrushforth The following commits have been pushed to master since your change was applied:

  • 0f87d20: 8244487: One Windows 10 SDK file missing from FX build
  • 4ec163d: 8242001: ChoiceBox: must update value on setting SelectionModel, part2
  • 236e2d6: 8244421: Wrong scrollbar position on touch enabled devices
  • 0385563: 8243255: Font size is large in JavaFX app with enabled Monocle on Raspberry Pi

Your commit was automatically rebased without conflicts.

Pushed as commit b0d66d0.

@kevinrushforth kevinrushforth deleted the kevinrushforth:8242508-vs2019 branch May 26, 2020
@palexdev
Copy link

@palexdev palexdev commented Mar 3, 2021

Can you also update the build script located in tools/scripts?
Build fails on my system with FAIL: WINSDK_DIR not defined
Also, it's not possible to install Windows SDK 7.1 on Windows 10, so that should be updated too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants